work

atelier-saulx · Sep 14, 2024 · 744a9bf · 744a9bf
1 parent fa9404e
commit 744a9bf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/components/Table/index.tsx b/src/components/Table/index.tsx
@@ -6,10 +6,9 @@ import { CheckboxInput } from '../CheckboxInput/index.js'
 import { styled } from 'inlines'
 import { useVirtualizer } from '../../hooks/useVirtualizer.js'
 
-// TODO virtualization
 // TODO better API for rowActions
 // TODO row onclick
-// TODO better padding when not selectable
+// TODO better padding when not selectable on the left (contact design)
 
 type TableInternal = {
   forceHover?: string

diff --git a/src/hooks/useVirtualizer.tsx b/src/hooks/useVirtualizer.tsx
@@ -11,7 +11,7 @@ function useVirtualizer({
   itemCount,
   itemHeight,
   scrollElementRef,
-  overScan = 4,
+  overScan: overScanProp,
 }: UseVirtualizerProps) {
   const [firstVisibleItemIndex, setFirstVisibleItemIndex] = useState(0)
   const [lastVisibleItemIndex, setLastVisibleItemIndex] = useState(0)
@@ -25,6 +25,8 @@ function useVirtualizer({
     const lastVisibleItemIndex =
       firstVisibleItemIndex + numberOfItemsVisibleAtOnce
 
+    let overScan = overScanProp ?? Math.ceil(numberOfItemsVisibleAtOnce / 2)
+
     setFirstVisibleItemIndex(Math.max(0, firstVisibleItemIndex - overScan))
     setLastVisibleItemIndex(
       Math.min(itemCount, lastVisibleItemIndex + overScan),