Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load mat #791

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Fix load mat #791

merged 3 commits into from
Jun 25, 2024

Conversation

lfarv
Copy link
Contributor

@lfarv lfarv commented Jun 25, 2024

This fixes a bug reported by @swhite2401 in #766.

@lfarv lfarv added Python For python AT code bug fix labels Jun 25, 2024
@lfarv lfarv requested a review from swhite2401 June 25, 2024 16:26
@lfarv
Copy link
Contributor Author

lfarv commented Jun 25, 2024

When this is approved, I will immediately publish a bug fix release 0.6.1.
For this, the license in the project metadata is also fixed.

@lfarv
Copy link
Contributor Author

lfarv commented Jun 25, 2024

For info, the .mat file contains strange attributes in the RingParam element. @swhite2401, can you remember if this file was created by a recent version?
Anyway these strange attributes are now ignored.

Copy link
Contributor

@swhite2401 swhite2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!
Question, can't we just assume that the lattice can have any attribute?

@swhite2401
Copy link
Contributor

For info, the .mat file contains strange attributes in the RingParam element. @swhite2401, can you remember if this file was created by a recent version? Anyway these strange attributes are now ignored.

This is an old version because this is the environment I create for FCC studies a while ago, can remember exactly when

@lfarv
Copy link
Contributor Author

lfarv commented Jun 25, 2024

can't we just assume that the lattice can have any attribute?

Yes, that's what it should be. The problem appeared with "deprecated attributes" which were kept for compatibility as properties. This created the bug and is now solved.

@lfarv lfarv merged commit cb61c7a into master Jun 25, 2024
37 checks passed
@lfarv lfarv deleted the fix_load_mat branch June 25, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Python For python AT code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants