Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a user's report on the use of random generators with MPI, this PR corrects 2 points:
reset_rng(rank=0, seed=n)
function, used for seeding the generators, behaved oddly and was not clearly documented. Up to now, the function needed to provide explicitly the MPI process rank to initialise correctly the process-specific generator (the so-called "thread" generator). Forgetting this resulted in all threads using the same random stream. Now by default,reset_rng
now uses the actual rank, so that the rank argument can be omitted. The documentation is improved.