Create BndStrMPoleSymplectic4RadPass #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any other comment? For me it's ok for merging. |
|
Ok for me! |
carmignani
requested changes
Oct 5, 2023
| } | ||
| else if (nrhs == 0) { | ||
| /* list of required fields */ | ||
| plhs[0] = mxCreateCellMatrix(8,1); |
There was a problem hiding this comment.
Hello,
it's a small detail, but this should be plhs[0] = mxCreateCellMatrix(9,1);
| mxSetCell(plhs[0],7,mxCreateString("NumIntSteps")); | ||
| mxSetCell(plhs[0],8,mxCreateString("Energy")); | ||
| if(nlhs>1) { /* list of optional fields */ | ||
| plhs[1] = mxCreateCellMatrix(7,1); |
There was a problem hiding this comment.
And this should be plhs[1] = mxCreateCellMatrix(10,1);
|
Anyone implementing these changes? |
|
Ok, actually I could do the commit directly online from gitHub on the forked version. |
carmignani
approved these changes
Oct 11, 2023
|
@carmignani If you add me as reviewer I can re-approve (needed after your changes and cannot be you) |
swhite2401
approved these changes
Oct 11, 2023
lnadolski
added a commit
that referenced
this pull request
Oct 25, 2023
# By Laurent Farvacque (14) and others # Via GitHub * master: (28 commits) Add passive beamloading cavity (#586) Create BndStrMPoleSymplectic4RadPass (#665) Documentation fixes (#669) Update of the build process (#659) New Matlab function atsimplering (#657) Collective bugfix (#664) Correct the attribute name of solenoids in Matlab (#663) Error parsing args for twiss_in and r_4d (#662) Fix atmaincavities (#656) Fix attribute names in Simple Ring (#655) Remove collective passes from internal lattice_pass (#650) The DPStep keyword in linopt6 raises an error for 4D lattices (#651) Bug fix in atdisable_6d: keep the Energy field in cavities. (#654) fix: ring phase advances in computeRDT.m (#652) Correct the axis definition in plot_sigma (#648) Don't automatically cache the location of RF cavities (#640) Simple ring model (#643) Correct Dipole tapering (#623) Chromatic functions extended (#644) Repair the Matlab tests (#645) ... # Conflicts: # atmat/Contents.m # atmat/atphysics/Radiation/atdisable_6d.m # atmat/atphysics/Radiation/atenable_6d.m # atmat/lattice/at2str.m # atmat/pubtools/create_elems/atidtable_dat.m # pyat/at/lattice/elements.py # pyat/at/lattice/lattice_object.py # pyat/at/physics/matrix.py # pyat/at/physics/radiation.py # pyat/examples/CollectiveEffects/RobinsonInstability.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hung-Chun Chao created BndStrMPoleSymplectic4RadPass to include synchrotron radiation damping for the straight-geometry bending magnet.