Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug reported in #592.
The fix for compiling with OpenMP was easy, but it revealed a problem with random generators.
This PR solves the problem of compilation failure with OPENMP=1, but OpenMP is disabled in the
BndMPoleSymplectic4QuantPass
,StrMPoleSymplectic4QuantPass
andQuantDiffPass
passmethods until the random generation of quantum emission is validated with OpenMP.I keep the issue #592 open because it documents the remaining problem. A dummy passmethod called
TestRandomPass
is temporarily added to the repository: it checks the random generators with and without OpenMP. The direct output of Gaussian distribution looks correct.