Fix compilation with OPENMP=1 #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…antPass and QuantDiffPass until the random generators are validated
|
Ok for for me, any idea on the problem with the RNG? |
swhite2401
approved these changes
May 31, 2023
It looks very strange. The results of TestRandomPass show the mean and std values of the generated numbers are correct and identical with and without OpenMP. The common and thread-specific behaviours are also correct. A next step will be to check if the problem lies in getting the number of emitted photons, or in computing their energy… |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug reported in #592.
The fix for compiling with OpenMP was easy, but it revealed a problem with random generators.
This PR solves the problem of compilation failure with OPENMP=1, but OpenMP is disabled in the
BndMPoleSymplectic4QuantPass,StrMPoleSymplectic4QuantPassandQuantDiffPasspassmethods until the random generation of quantum emission is validated with OpenMP.I keep the issue #592 open because it documents the remaining problem. A dummy passmethod called
TestRandomPassis temporarily added to the repository: it checks the random generators with and without OpenMP. The direct output of Gaussian distribution looks correct.