Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax chromaticity test for numpy 1.24 #545

Merged
merged 1 commit into from
Dec 20, 2022
Merged

relax chromaticity test for numpy 1.24 #545

merged 1 commit into from
Dec 20, 2022

Conversation

lfarv
Copy link
Contributor

@lfarv lfarv commented Dec 19, 2022

The linopt6 test suddenly started failing on Ubuntu. This is correlated with the release of numpy 1.24. The same code (stub branch) was running before merging:

Run python -m pytest test --cov-report term-missing --cov=at
============================= test session starts ==============================
platform linux -- Python 3.11.1, pytest-7.2.0, pluggy-1.0.0
system: Linux 5.15.0-1024-azure
numpy version: 1.23.5
rootdir: /home/runner/work/at/at
plugins: lazy-fixture-0.6.3, cov-4.0.0
collected 295 items

But now fails with a new numpy version:

Run python -m pytest test --cov-report term-missing --cov=at
============================= test session starts ==============================
platform linux -- Python 3.11.1, pytest-7.2.0, pluggy-1.0.0
system: Linux 5.15.0-1024-azure
numpy version: 1.24.0
rootdir: /home/runner/work/at/at
plugins: lazy-fixture-0.6.3, cov-4.0.0
collected 295 items

The chromaticity test between linopt2 and linopt6 must be relaxed from atol=1.e-12 to atol=5.e-11.
The accuracy is still good enough, but it's worrying that results may change with time…

The problem seems to be specific to Ubuntu

@lfarv lfarv added the Python For python AT code label Dec 19, 2022
@lfarv
Copy link
Contributor Author

lfarv commented Dec 20, 2022

Merged to unlock the tests in other branches. !

@lfarv lfarv merged commit b04bb2c into master Dec 20, 2022
@lfarv lfarv deleted the relax_llinopt6_test branch December 20, 2022 19:14
@lfarv lfarv mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python For python AT code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant