relax chromaticity test for numpy 1.24 #545
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linopt6 test suddenly started failing on Ubuntu. This is correlated with the release of numpy 1.24. The same code (stub branch) was running before merging:
But now fails with a new numpy version:
The chromaticity test between
linopt2
andlinopt6
must be relaxed fromatol=1.e-12
toatol=5.e-11
.The accuracy is still good enough, but it's worrying that results may change with time…
The problem seems to be specific to Ubuntu