-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for use of keep_lattice in find_orbit6(). #301
Conversation
I see that this test starts failing in 4f21954. Is this a valid test and something needs fixing? Or am I misunderstanding something? |
I think this is a problem that needs fixing, @lfarv, any idea? |
@willrogers: what you try is exactly how it is supposed to work. I see the problem, and strangely |
I have been debugging this morning. The difference is calling The problem is the call in
I think this call must be modifying the original lattice somehow. |
@willrogers: well spotted, thanks. |
I added a warning if you pass I update the |
I don't think the message is useful: |
8eda82b
to
7445ba2
Compare
This is how I expect to use the
keep_lattice
keyword argument, and it appears to be failing in pyat-0.2.0.The second call (with
keep_lattice=True
) is returning nan in each element of the array.Is this related to #299 ?
cc @MJGaughran