Switch Docker image source from Docker Hub to GHCR #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atc0005
added
enhancement
|
CI failures are due to v0.5.0 image uploads still WIP from a build machine. Will re-run CI jobs once the uploads complete. |
|
Note to future self: due to bandwidth issues between build box and destinations, it takes ~ 30 minutes to build & upload images. |
That was one source of the failures. Another is the Makefile-driven builds, tests, etc. That workflow assumes it is working with the standard/upstream golang image (which doesn't have customizations applied) which is not available via ghcr.io. |
atc0005
force-pushed
the
i210-switch-image-source-to-ghcr
branch
from
9cd2263
to
436b8da
Compare
- search/replace most image references - we're fortunate that hadolint is mirrored both places already - replace direct upstream reference for "latest" `golang` image with our "mirror" image which is a very lightly touched variation of that image (mostly metadata tweaks) refs GH-210 refs atc0005/go-ci#507
atc0005
force-pushed
the
i210-switch-image-source-to-ghcr
branch
from
436b8da
to
6828642
Compare
atc0005
added a commit
to atc0005/go-ci
that referenced
this pull request
Feb 3, 2022
- add new Dockerfile to build lightly touched variation of
upstream `golang` image
- add additional metadata tying the image to the atc0005/go-ci
repo
- update dependabot config to monitor the new Dockerfile for
image version updates
- update README to cover new image
- update Makefile to handle building and uploading new image
refs GH-507
refs atc0005/send2teams#211
refs atc0005/send2teams#210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes GH-210