Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker-based GitHub Actions Workflows #5

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Aug 23, 2020

CHANGES

Add GitHub Actions which use containers created and managed through
the atc0005/go-ci project.

This results in three workflows:

  • New, primary workflow

    • with parallel linting, testing and building tasks
    • with three Go environments
      • "old stable"
      • "stable"
      • "unstable"
        • this will be replaced with the next alpha, beta, rc release of
          Go and other linting tools that are not tested well enough to
          be considered "stable"
    • Makefile is not used in this workflow
    • staticcheck linting using latest stable version provided by the
      atc0005/go-ci containers
  • Separate Makefile-based linting and building workflow

    • intended to help ensure that local Makefile-based
      builds that are referenced in project README files
      continue to work as advertised until a better local
      tool can be discovered/explored further
    • use golang:latest container to allow for Makefile-based
      linting tooling installation testing since the
      atc0005/go-ci project provides containers with those
      tools already pre-installed
      • linting tasks use container-provided golangci-lint config file
        except for the Makefile-driven linting task which continues to
        use the repo-provided copy of the golangci-lint configuration
        file
  • Add Quick Validation workflow

    • run on every push, everything else on pull request updates
    • linting via golangci-lint only
    • testing
    • no builds

Other changes:

  • Makefile lintinstall recipe installs the very latest
    stable version of the golangci-lint binary instead
    of locking a specific version
    • this should reduce dependency "gardening"

REFERENCES

CHANGES

Add GitHub Actions which use containers created and managed through
the `atc0005/go-ci` project.

This results in three workflows:

- New, primary workflow
  - with parallel linting, testing and building tasks
  - with three Go environments
    - "old stable"
    - "stable"
    - "unstable"
      - this will be replaced with the next alpha, beta, rc release of
        Go and other linting tools that are not tested well enough to
        be considered "stable"
  - Makefile is *not* used in this workflow
  - `staticcheck` linting using latest stable version provided by the
    `atc0005/go-ci` containers

- Separate Makefile-based linting and building workflow
  - intended to help ensure that local Makefile-based
    builds that are referenced in project README files
    continue to work as advertised until a better local
    tool can be discovered/explored further
  - use `golang:latest` container to allow for Makefile-based
    linting tooling installation testing since the
    `atc0005/go-ci` project provides containers with those
    tools already pre-installed
    - linting tasks use container-provided `golangci-lint` config file
      *except* for the Makefile-driven linting task which continues to
      use the repo-provided copy of the `golangci-lint` configuration
      file

- Add Quick Validation workflow
  - run on every push, everything else on pull request updates
  - linting via `golangci-lint` only
  - testing
  - no builds

Other changes:

- Makefile `lintinstall` recipe installs the very latest
  stable version of the `golangci-lint` binary instead
  of locking a specific version
  - this should reduce dependency "gardening"

REFERENCES

- refs #1
- refs atc0005/todo#22
- see also the https://github.com/atc0005/go-ci project
@atc0005 atc0005 added this to the Next Release milestone Aug 23, 2020
@atc0005 atc0005 self-assigned this Aug 23, 2020
@atc0005
Copy link
Owner Author

atc0005 commented Aug 23, 2020

While the CI checks are failing pretty much across the board, the changes applied in this PR should be good. I'll sort through the CI failures with follow-up PRs.

@atc0005 atc0005 merged commit ff4dbec into master Aug 23, 2020
@atc0005 atc0005 deleted the i1-add-docker-ghaws branch August 23, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Docker-based GitHub Actions Workflows
1 participant