Fix Plugin.SetOutputTarget method
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New tests:
- `TestPluginSetOutputTargetIsValidWithValidInput`
- basic assertion to show that the method works as intended
with valid/expected input
- TestPluginSetOutputTargetIsValidWithInvalidInput
- asserts that when given an invalid output target that the
default/fallback output target is used instead
The second test is currently failing, highlighting the logic
bug currently affecting the `Plugin.SetOutputTarget` method.
refs GH-267
Correctly fallback to default output target when an invalid output target is provided. refs GH-267
atc0005
added
bug
atc0005
changed the title
Plugin.SetOutputTarget method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Plugin.SetOutputTargetTestPluginSetOutputTargetIsValidWithValidInputPlugin.SetOutputTargetfallback behaviorReferences