Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting issues exposed by linter upgrades #98

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Fix linting issues exposed by linter upgrades #98

merged 2 commits into from
Nov 9, 2021

Commits on Nov 9, 2021

  1. Ignore false-positive gosec G307 linting errors 

    Issues reported after upgrading golangci-lint to v1.43.0.
gosec was updated in that version from v2.8.1 to v2.9.1.

refs #97
refs golangci/golangci-lint#2299
    @atc0005
    atc0005 committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    23e65b2 View commit details
    Browse the repository at this point in the history

  2. Ignore gocritic regexp.Compile() linting error 

    I am already checking for the regex compile error and
immediately returning the error if it occurs. I expect
that the error wrapping I am providing will be more
readable to users than an intentional panic induced
stack trace would be.

refs GH-96
    @atc0005
    atc0005 committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    dd697e0 View commit details
    Browse the repository at this point in the history