Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework images #874

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Rework images #874

merged 1 commit into from
Feb 21, 2023

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Feb 21, 2023

Overview

  • move existing go-ci-oldstable, go-ci-stable and go-ci-unstable images into combined subdirectories to better communicate intent
  • move .golangci.yml files into the combined subdirectories
  • create new build/release Dockerfiles for each of stable, oldstable and unstable variants
    • the intent of these images is to provide a baseline build environment for dev and release builds vs the "matrix" CI builds performed by the combined images
    • provide tc-hib/go-winres build tool
      • for embedding Windows metadata into Windows binaries
    • provide goreleaser/nfpm build tool - for generating installation packages (e.g., RPM, DEB)
  • update go-ci-stable-alpine-buildx64 image
    • provide build tools
  • update go-ci-stable-alpine-buildx86 image
    • provide build tools
  • update go-ci-stable-cgo-mingw-w64-build image
    • provide build tools
  • add go-ci-stable-build image
    • provide build tools
  • add go-ci-oldstable-build image
    • provide build tools
  • add go-ci-unstable-build image
    • provide build tools
  • README
    • update existing image names
    • add new images
    • add build tools provided
    • explicitly list which images provide build tools
    • explicitly list which images provide linting tools
    • attempt to group images by purpose
      • Matrix images
      • General build images - Mirror build images - Release build images
  • Makefile
    • update image names to reflect changes
    • update paths to reflect content shuffling
    • update recipes to build new images
    • add prune recipe to aggressively reclaim disk space on image build host

References

- move existing `go-ci-oldstable`, `go-ci-stable`
  and `go-ci-unstable` images into `combined`
  subdirectories to better communicate intent
- move `.golangci.yml` files into the `combined`
  subdirectories
- create new `build/release` Dockerfiles for each
  of `stable`, `oldstable` and `unstable` variants
  - the intent of these images is to provide a baseline
    build environment for dev and release builds
    vs the "matrix" CI builds performed by the `combined`
    images
  - provide `tc-hib/go-winres` build tool
    - for embedding Windows metadata into Windows binaries
  - provide `goreleaser/nfpm` build tool
    - for generating installation packages (e.g., RPM, DEB)
- update `go-ci-stable-alpine-buildx64` image
  - provide build tools
- update `go-ci-stable-alpine-buildx86` image
  - provide build tools
- update `go-ci-stable-cgo-mingw-w64-build` image
  - provide build tools
- add `go-ci-stable-build` image
  - provide build tools
- add `go-ci-oldstable-build` image
  - provide build tools
- add `go-ci-unstable-build` image
  - provide build tools
- README
  - update existing image names
  - add new images
  - add build tools provided
  - explicitly list which images provide build tools
  - explicitly list which images provide linting tools
  - attempt to group images by purpose
    - Matrix images
    - General build images
    - Mirror build images
    - Release build images
- Makefile
  - update image names to reflect changes
  - update paths to reflect content shuffling
  - update recipes to build new images
  - add `prune` recipe to aggressively reclaim disk space on image
    build host

refs GH-847
@atc0005 atc0005 added this to the Next Release milestone Feb 21, 2023
@atc0005 atc0005 self-assigned this Feb 21, 2023
@atc0005 atc0005 merged commit 36064de into master Feb 21, 2023
@atc0005 atc0005 deleted the i847-add-release-build-images branch February 21, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant