Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split makefile build recipe into sub recipes, call each from GHAW #723

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Split makefile build recipe into sub recipes, call each from GHAW #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49a343d
Split Makefile build task into sub-recipes
atc0005 Sep 6, 2022
bed1bea
Update GHAW to call specific subrecipes
atc0005 Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 162 additions & 2 deletions .github/workflows/build-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ on:
types: [opened, synchronize]

jobs:
build_images_using_makefile:
name: Build images using Makefile
build_all_images_using_makefile:
name: Build all images using Makefile
runs-on: ubuntu-latest
# Default: 360 minutes
timeout-minutes: 10
Expand All @@ -35,3 +35,163 @@ jobs:

- name: Build images using project Makefile
run: make build

build_stable_image_using_makefile:
name: Build stable image using Makefile
runs-on: ubuntu-latest
# Default: 360 minutes
timeout-minutes: 10

steps:
- name: Print Docker version
run: docker --version

- name: Check out code into the Go module directory
uses: actions/checkout@v3

# bsdmainutils provides "column" which is used by the Makefile
- name: Install Ubuntu packages
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends make gcc bsdmainutils

- name: Build stable image
run: make build-stable

build_alpine_x64_image_using_makefile:
name: Build Alpine x64 image using Makefile
runs-on: ubuntu-latest
# Default: 360 minutes
timeout-minutes: 10

steps:
- name: Print Docker version
run: docker --version

- name: Check out code into the Go module directory
uses: actions/checkout@v3

# bsdmainutils provides "column" which is used by the Makefile
- name: Install Ubuntu packages
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends make gcc bsdmainutils

- name: Build Alpine x64 image
run: make build-stable-alpine-buildx64

build_alpine_x86_image_using_makefile:
name: Build Alpine x86 image using Makefile
runs-on: ubuntu-latest
# Default: 360 minutes
timeout-minutes: 10

steps:
- name: Print Docker version
run: docker --version

- name: Check out code into the Go module directory
uses: actions/checkout@v3

# bsdmainutils provides "column" which is used by the Makefile
- name: Install Ubuntu packages
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends make gcc bsdmainutils

- name: Build Alpine x86 image
run: make build-stable-alpine-buildx86

build_stable_debian_image_using_makefile:
name: Build stable Debian image using Makefile
runs-on: ubuntu-latest
# Default: 360 minutes
timeout-minutes: 10

steps:
- name: Print Docker version
run: docker --version

- name: Check out code into the Go module directory
uses: actions/checkout@v3

# bsdmainutils provides "column" which is used by the Makefile
- name: Install Ubuntu packages
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends make gcc bsdmainutils

- name: Build stable Debian image
run: make stable-debian-build

build_stable_mirror_image_using_makefile:
name: Build stable mirror image using Makefile
runs-on: ubuntu-latest
# Default: 360 minutes
timeout-minutes: 10

steps:
- name: Print Docker version
run: docker --version

- name: Check out code into the Go module directory
uses: actions/checkout@v3

# bsdmainutils provides "column" which is used by the Makefile
- name: Install Ubuntu packages
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends make gcc bsdmainutils

- name: Build stable mirror image
run: make stable-mirror-build

build_stable_linting_only_image_using_makefile:
name: Build stable linting-only image using Makefile
runs-on: ubuntu-latest
# Default: 360 minutes
timeout-minutes: 10

steps:
- name: Print Docker version
run: docker --version

- name: Check out code into the Go module directory
uses: actions/checkout@v3

# bsdmainutils provides "column" which is used by the Makefile
- name: Install Ubuntu packages
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends make gcc bsdmainutils

- name: Build stable linting-only image
run: make stable-linting-only

build_oldstable_image_using_makefile:
name: Build oldstable image using Makefile
runs-on: ubuntu-latest
# Default: 360 minutes
timeout-minutes: 10

steps:
- name: Print Docker version
run: docker --version

- name: Check out code into the Go module directory
uses: actions/checkout@v3

# bsdmainutils provides "column" which is used by the Makefile
- name: Install Ubuntu packages
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends make gcc bsdmainutils

- name: Build oldstable image
run: make build-oldstable

build_unstable_image_using_makefile:
name: Build unstable image using Makefile
runs-on: ubuntu-latest
# Default: 360 minutes
timeout-minutes: 10

steps:
- name: Print Docker version
run: docker --version

- name: Check out code into the Go module directory
uses: actions/checkout@v3

# bsdmainutils provides "column" which is used by the Makefile
- name: Install Ubuntu packages
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends make gcc bsdmainutils

- name: Build unstable image
run: make build-unstable
80 changes: 63 additions & 17 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,21 +104,9 @@ linting:
docker run --pull never --rm -i -v "$$PWD/$$target:$$PWD/$$target" $(DOCKER_IMAGE_HADOLINT) hadolint $$PWD/$$target; \
done

.PHONY: build
## build: build all Docker container images
build:
@echo "Building Docker container images"

@echo "Bundle linter config files to provide baseline default settings"
@for version in {oldstable,unstable,stable/linting,stable/combined,stable/build/debian}; do cp -vf .markdownlint.yml $$version/; done

# unstable container image has its own copy of the .golangci.yml file
# oldstable container image has its own copy of the .golangci.yml file
# stable container images share a copy of the .golangci.yml file
@for version in {stable/linting,stable/combined,stable/build/debian}; do cp -vf stable/.golangci.yml $$version/; done

@echo "List Docker version"
@docker version
.PHONY: build-stable
## build-stable: Build stable image
build-stable: pre-build

@echo "Building stable release"
sudo docker image build \
Expand All @@ -134,8 +122,13 @@ build:
--label=$(DOCKER_IMAGE_OWNER_LABEL) \
--label=$(DOCKER_IMAGE_REVISION_LABEL) \
--label=$(DOCKER_IMAGE_CREATED_LABEL)
@echo "Completed build of stable release"

.PHONY: build-stable-alpine-buildx64
## build-stable-alpine-buildx64: Build Alpine x64 image
build-stable-alpine-buildx64: pre-build

@echo "Building stable-alpine-build.x64 release"
@echo "Building stable-alpine-buildx64 release"
sudo docker image build \
--pull \
--no-cache \
Expand All @@ -147,8 +140,13 @@ build:
--label=$(DOCKER_IMAGE_OWNER_LABEL) \
--label=$(DOCKER_IMAGE_REVISION_LABEL) \
--label=$(DOCKER_IMAGE_CREATED_LABEL)
@echo "Completed build of stable-alpine-buildx64 release"

@echo "Building stable-alpine-build x86 release"
.PHONY: build-stable-alpine-buildx86
## build-stable-alpine-buildx86: Build Alpine x86 image
build-stable-alpine-buildx86: pre-build

@echo "Building stable-alpine-buildx86 release"
sudo docker image build \
--pull \
--no-cache \
Expand All @@ -160,6 +158,11 @@ build:
--label=$(DOCKER_IMAGE_OWNER_LABEL) \
--label=$(DOCKER_IMAGE_REVISION_LABEL) \
--label=$(DOCKER_IMAGE_CREATED_LABEL)
@echo "Completed build of stable-alpine-buildx86 release"

.PHONY: stable-debian-build
## stable-debian-build: Build Debian image
stable-debian-build: pre-build

@echo "Building stable-debian-build release"
sudo docker image build \
Expand All @@ -173,6 +176,11 @@ build:
--label=$(DOCKER_IMAGE_OWNER_LABEL) \
--label=$(DOCKER_IMAGE_REVISION_LABEL) \
--label=$(DOCKER_IMAGE_CREATED_LABEL)
@echo "Completed build of stable-debian-build release"

.PHONY: stable-mirror-build
## stable-mirror-build: Build stable mirror image
stable-mirror-build: pre-build

@echo "Building stable-mirror-build release"
sudo docker image build \
Expand All @@ -186,6 +194,11 @@ build:
--label=$(DOCKER_IMAGE_OWNER_LABEL) \
--label=$(DOCKER_IMAGE_REVISION_LABEL) \
--label=$(DOCKER_IMAGE_CREATED_LABEL)
@echo "Completed build of stable-mirror-build release"

.PHONY: stable-linting-only
## stable-linting-only: Build stable linting-only image
stable-linting-only: pre-build

@echo "Building stable linting-only release"
sudo docker image build \
Expand All @@ -199,6 +212,11 @@ build:
--label=$(DOCKER_IMAGE_OWNER_LABEL) \
--label=$(DOCKER_IMAGE_REVISION_LABEL) \
--label=$(DOCKER_IMAGE_CREATED_LABEL)
@echo "Completed build of stable-linting-only release"

.PHONY: build-oldstable
## build-oldstable: Build oldstable image
build-oldstable: pre-build

@echo "Building oldstable release"
sudo docker image build \
Expand All @@ -212,6 +230,11 @@ build:
--label=$(DOCKER_IMAGE_OWNER_LABEL) \
--label=$(DOCKER_IMAGE_REVISION_LABEL) \
--label=$(DOCKER_IMAGE_CREATED_LABEL)
@echo "Completed build of oldstable release"

.PHONY: build-unstable
## build-unstable: Build unstable image
build-unstable: pre-build

@echo "Building unstable release"
sudo docker image build \
Expand All @@ -225,6 +248,29 @@ build:
--label=$(DOCKER_IMAGE_OWNER_LABEL) \
--label=$(DOCKER_IMAGE_REVISION_LABEL) \
--label=$(DOCKER_IMAGE_CREATED_LABEL)
@echo "Completed build of unstable release"

.PHONY: pre-build
## pre-build: pre-build tasks
pre-build:

@echo "Building Docker container images"

@echo "Bundle linter config files to provide baseline default settings"
@for version in {oldstable,unstable,stable/linting,stable/combined,stable/build/debian}; do cp -vf .markdownlint.yml $$version/; done

# unstable container image has its own copy of the .golangci.yml file
# oldstable container image has its own copy of the .golangci.yml file
# stable container images share a copy of the .golangci.yml file
@for version in {stable/linting,stable/combined,stable/build/debian}; do cp -vf stable/.golangci.yml $$version/; done

@echo "List Docker version"
@docker version


.PHONY: build
## build: build all Docker container images
build: pre-build build-stable build-stable-alpine-buildx64 build-stable-alpine-buildx86 stable-debian-build stable-mirror-build stable-linting-only build-oldstable build-unstable

@echo "Remove temporary copies of bundled files"
@rm -vf {oldstable,unstable,stable/linting,stable/combined,stable/build/debian}/.markdownlint.yml
Expand Down