Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable golangci-lint linters incompatible with Go 1.18 #568

Closed
atc0005 opened this issue Mar 21, 2022 · 0 comments
Closed

Disable golangci-lint linters incompatible with Go 1.18 #568

atc0005 opened this issue Mar 21, 2022 · 0 comments
Assignees
@atc0005
Labels
linting unstable
Milestone
v0.6.4

Comments

@atc0005
Copy link
Owner

atc0005 commented Mar 21, 2022

Per golangci/golangci-lint#2649 these linters are incompatible with Go 1.18:

  • bodyclose
  • contextcheck
  • gocritic
    • hugeParam
  • gosimple
  • govet
    • nilness
    • unusedwrite
  • nilerr
  • noctx
  • rowserrcheck
  • sqlclosecheck
  • staticcheck
  • structcheck
  • stylecheck
  • tparallel
  • unparam
  • unused
  • wastedassign

We should explicitly disable these linters in the unstable .golangci.yml file.
@atc0005 atc0005 added this to the v0.6.4 milestone Mar 21, 2022
@atc0005 atc0005 self-assigned this Mar 21, 2022
atc0005 added a commit that referenced this issue Mar 21, 2022
@atc0005
Disable incompatible linters for unstable image
bc3cfd9 
Explicitly disable linters and analyzers confirmed to not
work (at all or "well") with Go 1.18.

The goal is to re-enable linters as future releases of
golangci-lint resolve compatibility issues.

refs GH-568
refs golangci/golangci-lint#2649
@atc0005 atc0005 mentioned this issue Mar 21, 2022
Merged
@atc0005 atc0005 closed this as completed Mar 21, 2022
@atc0005 atc0005 mentioned this issue Apr 2, 2022
Open
@atc0005 atc0005 mentioned this issue May 10, 2022
Closed
atc0005 added a commit that referenced this issue May 10, 2022
@atc0005
Enable staticcheck in golangci-lint unstable image
51af0af 
The staticcheck linter now supports Go 1.18. Re-enable so
that it can be used by golangci-lint.

refs GH-622
refs GH-568
@atc0005 atc0005 mentioned this issue May 10, 2022
Merged
@atc0005 atc0005 mentioned this issue Jun 19, 2022
Closed
This was referenced Jul 19, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
linting unstable
Projects
None yet
Milestone
v0.6.4
Development

No branches or pull requests
1 participant
@atc0005