Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfiles, README, Makefile incorrectly refer to images as "containers" #508

Closed
atc0005 opened this issue Feb 3, 2022 · 1 comment · Fixed by #510
Closed

Dockerfiles, README, Makefile incorrectly refer to images as "containers" #508

atc0005 opened this issue Feb 3, 2022 · 1 comment · Fixed by #510
Assignees
@atc0005
Labels
bug Something isn't working documentation Improvements or additions to documentation Makefile oldstable stable stable-build-only stable-lint-only unstable
Milestone
v0.6.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Feb 3, 2022

Example:

go-ci/stable/linting/Dockerfile

Lines 34 to 36 in 672ed4e

LABEL org.opencontainers.image.description="Docker container intended for lightweight \
linting and testing of Go code. Based on current golangci-lint \
image. Intended for lightweight testing of iterative branch changes."

It should say image, not container.
@atc0005 atc0005 added bug Something isn't working documentation Improvements or additions to documentation oldstable unstable stable stable-lint-only stable-build-only labels Feb 3, 2022
@atc0005 atc0005 added this to the Next Release milestone Feb 3, 2022
@atc0005 atc0005 self-assigned this Feb 3, 2022
@atc0005 atc0005 changed the title org.opencontainers.image.description LABEL incorrectly notes that images are "containers" Dockerfiles, README, Makefile incorrectly refer to images as "containers" Feb 3, 2022
@atc0005
Copy link
Owner Author

atc0005 commented Feb 3, 2022

Looks like the usage is sprinkled through many files, not just the Dockerfiles.

atc0005 added a commit that referenced this issue Feb 3, 2022
@atc0005
Correct Docker container references
2971c25 
Refer to images as "Docker container images", not "Docker
containers" or just "containers".

Attempting to apply some consistency.

refs GH-508
@atc0005 atc0005 mentioned this issue Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working documentation Improvements or additions to documentation Makefile oldstable stable stable-build-only stable-lint-only unstable
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Correct Docker container references atc0005/go-ci
1 participant
@atc0005