Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore orijtech/structslop for use with Go 1.23 images #1684

Closed
atc0005 opened this issue Aug 14, 2024 · 1 comment
Closed

Restore orijtech/structslop for use with Go 1.23 images #1684

atc0005 opened this issue Aug 14, 2024 · 1 comment
Assignees
@atc0005
Labels
dependencies linting stable unstable
Milestone
v0.21.9

Comments

@atc0005
Copy link
Owner

atc0005 commented Aug 14, 2024

Overview

The orijtech/structslop linter fails to build using Go 1.23rc1 and newer with default build options. As a result it was removed from the unstable linting image.

A workaround is to build using -ldflags=-checklinkname=0.

We can restore this linter to the unstable linting image and include that build option.

Additionally, now that Go 1.23 is the new "stable" series we can add that build option to the stable linting image.

References
@atc0005 atc0005 added this to the Next Release milestone Aug 14, 2024
@atc0005 atc0005 self-assigned this Aug 14, 2024
@atc0005 atc0005 mentioned this issue Aug 14, 2024
Closed
atc0005 added a commit that referenced this issue Aug 15, 2024
@atc0005
Restore orijtech/structslop linter
f61dc77 
Revert earlier change that removed this linter from the
`unstable` image.

refs GH-1684
@atc0005 atc0005 mentioned this issue Aug 15, 2024
Merged
atc0005 added a commit that referenced this issue Aug 15, 2024
@atc0005
Restore orijtech/structslop linter
740321c 
Revert earlier change that removed this linter from the
`unstable` image.

Also, explicitly use `-ldflags=-checklinkname=0` when building
the linter to work around changes in Go 1.23.

refs GH-1684
@atc0005
Copy link
Owner Author

atc0005 commented Aug 15, 2024

Fixed per #1688.

@atc0005 atc0005 closed this as completed Aug 15, 2024
atc0005 added a commit that referenced this issue Aug 15, 2024
@atc0005
Update stable img structslop install options
bb452d3 
Explicitly use `-ldflags=-checklinkname=0` when building
the linter to work around changes in Go 1.23 now that this
image has has switched from providing Go 1.22 to 1.23.

refs GH-1666
refs GH-1684
@atc0005 atc0005 mentioned this issue Aug 15, 2024
Merged
atc0005 added a commit that referenced this issue Aug 15, 2024
@atc0005
Update stable img structslop install options
02d0bba 
Explicitly use `-ldflags=-checklinkname=0` when building
the linter to work around changes in Go 1.23 now that this
image has has switched from providing Go 1.22 to 1.23.

refs GH-1666
refs GH-1684
atc0005 added a commit to atc0005/shared-project-resources that referenced this issue Aug 16, 2024
@atc0005
Revert "Disable structslop linter for unstable image"
145a01e 
This reverts commit 53521c3.

refs #209
refs atc0005/go-ci#1684
@atc0005 atc0005 mentioned this issue Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
dependencies linting stable unstable
Projects
None yet
Milestone
v0.21.9
Development

No branches or pull requests
1 participant
@atc0005