Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add architecture specification to all Dockerfiles #1344

Closed
atc0005 opened this issue Feb 7, 2024 · 0 comments · Fixed by #1371
Closed

Add architecture specification to all Dockerfiles #1344

atc0005 opened this issue Feb 7, 2024 · 0 comments · Fixed by #1371
Assignees
@atc0005
Labels
dependencies enhancement New feature or request oldstable stable unstable
Milestone
v0.15.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Feb 7, 2024

Overview

i386 variants of Dockerfile images are already explicitly specified.

Example:

go-ci/oldstable/build/alpine-x86/Dockerfile

Line 10 in f15ca9a

FROM i386/golang:1.20.14-alpine3.18

We are not yet specifying explicitly which images are expected to be amd64 variants.

Example:

go-ci/oldstable/build/alpine-x64/Dockerfile

Line 10 in f15ca9a

FROM golang:1.20.13-alpine3.18

I should do that to help avoid issues with images offered for the wrong architecture and to clarify the intent.

References
@atc0005 atc0005 added this to the v0.14.10 milestone Feb 7, 2024
@atc0005 atc0005 self-assigned this Feb 7, 2024
@atc0005 atc0005 pinned this issue Feb 7, 2024
atc0005 added a commit that referenced this issue Feb 9, 2024
@atc0005
Add architecture specification to all Dockerfiles
4317bb7 
Add `amd64/` prefix to all Dockerfiles which do not already
explicitly use the `i386/` prefix.

refs GH-1344
@atc0005 atc0005 mentioned this issue Feb 9, 2024
Merged
@atc0005 atc0005 unpinned this issue Feb 12, 2024
@atc0005 atc0005 mentioned this issue Mar 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
dependencies enhancement New feature or request oldstable stable unstable
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

Add architecture specification to all Dockerfiles atc0005/go-ci
1 participant
@atc0005