Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UNKNOWN state for perfdata add failure #204

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Mar 7, 2023

  • abort with UNKNOWN state when failing to add/gather generated performance data
  • remove duplicate perfdata add step
    • both the problem & OK state switch case blocks attempted to add perfdata metrics. Instead of updating the second to use an UNKNOWN exit state we just move the step outside of the switch statement so the step is performed just once

refs GH-196

@atc0005 atc0005 added bug Something isn't working output/summary Service Output (aka, "one-line-summary") output/perfdata Service Perf Data (aka, "performance data") app/check_statuspage_components labels Mar 7, 2023
@atc0005 atc0005 added this to the Next Release milestone Mar 7, 2023
@atc0005 atc0005 self-assigned this Mar 7, 2023
- abort with UNKNOWN state when failing to add/gather generated
  performance data
- remove duplicate perfdata add step
  - both the problem & OK state switch case blocks attempted
    to add perfdata metrics. Instead of updating the second to
    use an UNKNOWN exit state we just move the step outside of
    the switch statement so the step is performed just once

refs GH-196
@atc0005 atc0005 force-pushed the i196-use-unknown-state-for-failure-to-add-perfdata branch from 5873814 to 348c7db Compare March 7, 2023 12:01
@atc0005 atc0005 merged commit 20c09f5 into master Mar 7, 2023
@atc0005 atc0005 deleted the i196-use-unknown-state-for-failure-to-add-perfdata branch March 7, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app/check_statuspage_components bug Something isn't working exit state output/perfdata Service Perf Data (aka, "performance data") output/summary Service Output (aka, "one-line-summary")
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant