Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "canary" tools go file for tc-hib/go-winres releases #248

Closed
atc0005 opened this issue Dec 17, 2021 · 1 comment · Fixed by #252
Closed

Add "canary" tools go file for tc-hib/go-winres releases #248

atc0005 opened this issue Dec 17, 2021 · 1 comment · Fixed by #252

Comments

@atc0005
Copy link
Owner

atc0005 commented Dec 17, 2021

Same concept currently used by the Dockerfile monitored by Dependabot. Whenever there is a new release of this package, a PR should be opened in this project for review. Depending on the changes, I'll need to update the build environment to include this new release.

Additionally (and likely a tangent issue), the Makefile recipe used to install linting tools, perform builds, etc. should also assert that this took is present or at least offer a recipe for installing the tool as requested (similar to linting tools installation).

All of this said, it may be that this is already taken care of by the current build process (I've not double-checked that detail as I'm filing this issue for later).

See also #200.

@atc0005 atc0005 added this to the Future milestone Dec 17, 2021
@atc0005 atc0005 self-assigned this Dec 17, 2021
@atc0005
Copy link
Owner Author

atc0005 commented Dec 17, 2021

Additionally (and likely a tangent issue), the Makefile recipe used to install linting tools, perform builds, etc. should also assert that this took is present or at least offer a recipe for installing the tool as requested (similar to linting tools installation).

All of this said, it may be that this is already taken care of by the current build process (I've not double-checked that detail as I'm filing this issue for later).

Already taken care of via the gogeninstall recipe, but not handled by the Build codebase GitHub Actions workflow:

build_code:
name: Build codebase
runs-on: ubuntu-latest
# Default: 360 minutes
timeout-minutes: 10
strategy:
matrix:
container-image: ["go-ci-oldstable", "go-ci-stable", "go-ci-unstable"]
container:
image: "index.docker.io/atc0005/go-ci:${{ matrix.container-image}}"
steps:
- name: Print go version
run: go version
- name: Check out code
uses: actions/[email protected]
- name: Build using vendored dependencies
run: |
go build -v -mod=vendor ./cmd/check_imap_mailbox

That workflow is missing an entry to build the list-emails CLI app.

Need to file this as a separate issue.

@atc0005 atc0005 modified the milestones: Future, v0.4.13 Dec 28, 2021
atc0005 added a commit that referenced this issue Dec 28, 2021
- Add tools.go and go.mod files to track go-winres releases
- Explicitly specify one version back (v0.2.3) to test
  Dependabot monitoring of go-winres release versions

Place the files in the same path as the Go Dockerfile used
for a similar purpose.

refs GH-248
atc0005 added a commit that referenced this issue Dec 28, 2021
Explicitly have Dependabot monitor /dependabot/tools/go.mod
for tools version updates.

refs GH-248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant