Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Upgrade pelletier/go-toml from 1.x to v2 #296

Merged
merged 2 commits into from
May 11, 2022

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented May 10, 2022

Apply changes previously applied for GH-289

  • update go.mod, go.sum
  • update NOTICE.txt to reflect updated library license text
  • update vendored files
  • swap out use of v1 library for v2

Apply additional changes to comply with pelletier/go-toml v2

Explicitly add toml struct tags to configTemplate

These tags are needed to ensure compatibility with pelletier/go-toml v2 changes (which were made to more closely reflect encoding/json standard library behavior).

Use pelletier/go-toml@c5ca2c6 which contains a bugfix for anonymous structs.

Will switch to the next upstream tag once it is available.

References

atc0005 added 2 commits May 10, 2022 06:49
- update go.mod, go.sum
- update NOTICE.txt to reflect updated library license text
- update vendored files
- swap out use of v1 library for v2

refs GH-289
refs GH-295
These tags are needed to ensure compatibility with
`pelletier/go-toml` v2 changes (which were made to more closely
reflect encoding/json standard library behavior).

Use pelletier/go-toml@c5ca2c6
which contains a bugfix for anonymous structs.

Will switch to the next upstream tag once it is available.

refs GH-295
@atc0005 atc0005 added bug Something isn't working dependencies labels May 10, 2022
@atc0005 atc0005 added this to the Next Release milestone May 10, 2022
@atc0005 atc0005 self-assigned this May 10, 2022
@atc0005 atc0005 merged commit 523df3d into master May 11, 2022
@atc0005 atc0005 deleted the i295-upgrade-pelletier-go-toml-to-v2 branch May 11, 2022 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace pelletier/go-toml v1.x with v2
1 participant