Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Config file parsing broken after pelletier/go-toml v1 to v2 upgrade #292

Closed
atc0005 opened this issue May 9, 2022 · 0 comments · Fixed by #293
Closed

Config file parsing broken after pelletier/go-toml v1 to v2 upgrade #292

atc0005 opened this issue May 9, 2022 · 0 comments · Fixed by #293
Assignees
Labels
bug Something isn't working config dependencies
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented May 9, 2022

From #289 (comment):

See also:

May need to revisit how this project is using the package, may need to revert to v1.

A brief test suggests that this is correct. Due to how the config structure is setup, this project is affected by the v1 to v2 changes.

Waiting on an upstream bug report response to determine whether I've encountered a regression or an intentional change in functionality for the v2 series.

For the time being, it's probably best to downgrade the pelletier/go-toml library from v2 to v1 to restore full config file functionality.

@atc0005 atc0005 added bug Something isn't working config labels May 9, 2022
@atc0005 atc0005 added this to the Next Release milestone May 9, 2022
@atc0005 atc0005 self-assigned this May 9, 2022
atc0005 added a commit that referenced this issue May 9, 2022
This is needed to resolve breakage encountered with upstream
v2 changes. Waiting on upstream response to determine
next steps.

refs GH-292
atc0005 added a commit that referenced this issue May 9, 2022
This is needed to resolve breakage encountered with upstream
v2 changes. Waiting on upstream response to determine
next steps.

refs GH-292
@atc0005 atc0005 changed the title Revert pelletier/go-toml from v2 to v1 Config file parsing broken after pelletier/go-toml v1 to v2 upgrade May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working config dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant