This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
Add support for specifying notification settings via flags, config file #19
Comments
|
Adding a new setting to tune the rate limit for notifications as part of GH-85. Still a number of other settings remain however. |
atc0005
added a commit
that referenced
this issue
Jul 11, 2020
SUMMARY As a follow-up to GH-87, this commit exposes a new setting that allows directly configuring the rate limit used for Teams notifications. GH-3 will be responsible for exposing the same setting for email notifications. CHANGES - update documentation to note new setting - README - GoDoc - configure - configuration file - new `rate_limit` setting - code - remove rate limit constants in favor of external settings (email rate limit setting scheduled for GH-3) and default const value if not specified externally - new `TeamsNotificationRateLimit` getter func - new `EmailNotificationRateLimit` getter func - stub only; further work scheduled for GH-3 REFERENCES refs GH-87, GH-85, GH-19, GH-3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As I'm pulling in existing notifications support from the atc0005/bounce project, I'm finding that a large chunk of constants are configured for settings that are probably going to end up being site-specific. For the early release I'm fine with them remaining constants (e.g., "let's just get it working" MVP mindset), but I'd like to loop back and change the current constants to a set of defaults and expose the settings via config flags and file. Due to the sheer number of them they may require a few new config file sections.
Tangent: I'm not yet sure whether exposing 1:1 flags and config file settings is manageable over the long haul, so some of these may end up as config file "tunibles" only.
The text was updated successfully, but these errors were encountered: