Merge pull request #453 from atc0005/fix-goconst-linting-errors

Fix goconst linting errors
atc0005 · Nov 17, 2023 · 619cc30 · 619cc30
2 parents 2a71d1f + 38490e3
commit 619cc30
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/cmd/brick/constants.go b/cmd/brick/constants.go
@@ -18,3 +18,9 @@ package main
 
 // MB represents 1 Megabyte
 const MB int64 = 1048576
+
+const (
+	recordActionStep2of3      string = "[step 2 of 3]"
+	recordActionStep3of3      string = "[step 3 of 3]"
+	recordActionUnknownRecord string = "[UNKNOWN]"
+)
diff --git a/cmd/brick/message.go b/cmd/brick/message.go
@@ -176,28 +176,28 @@ func getMsgTitle(msgTitlePrefix string, record events.Record) string {
 	// TODO: Calculate step labeling based off of enabled features (see GH-65).
 
 	case events.ActionSuccessDisableRequestReceived, events.ActionFailureDisableRequestReceived:
-		msgCardTitle = msgTitlePrefix + "[step 1 of 3] " + record.Action
+		msgCardTitle = msgTitlePrefix + recordActionStep2of3 + " " + record.Action
 
 	case events.ActionSuccessDisabledUsername, events.ActionFailureDisabledUsername:
-		msgCardTitle = msgTitlePrefix + "[step 2 of 3] " + record.Action
+		msgCardTitle = msgTitlePrefix + recordActionStep2of3 + " " + record.Action
 
 	case events.ActionSuccessDuplicatedUsername, events.ActionFailureDuplicatedUsername:
-		msgCardTitle = msgTitlePrefix + "[step 2 of 3] " + record.Action
+		msgCardTitle = msgTitlePrefix + recordActionStep2of3 + " " + record.Action
 
 	case events.ActionSuccessIgnoredUsername, events.ActionFailureIgnoredUsername:
-		msgCardTitle = msgTitlePrefix + "[step 2 of 3] " + record.Action
+		msgCardTitle = msgTitlePrefix + recordActionStep2of3 + " " + record.Action
 
 	case events.ActionSuccessIgnoredIPAddress, events.ActionFailureIgnoredIPAddress:
-		msgCardTitle = msgTitlePrefix + "[step 2 of 3] " + record.Action
+		msgCardTitle = msgTitlePrefix + recordActionStep2of3 + " " + record.Action
 
 	case events.ActionSuccessTerminatedUserSession,
 		events.ActionFailureUserSessionLookupFailure,
 		events.ActionFailureTerminatedUserSession,
 		events.ActionSkippedTerminateUserSessions:
-		msgCardTitle = msgTitlePrefix + "[step 3 of 3] " + record.Action
+		msgCardTitle = msgTitlePrefix + recordActionStep3of3 + " " + record.Action
 
 	default:
-		msgCardTitle = msgTitlePrefix + " [UNKNOWN] " + record.Action
+		msgCardTitle = msgTitlePrefix + " " + recordActionUnknownRecord + " " + record.Action
 		log.Warnf("UNKNOWN record: %v+\n", record)
 	}