Add support for Microsoft Teams notifications

ADDED - Add support for Microsoft Teams notifications - configurable retry, retry delay settings - rate-limited submissions to help prevent unintentional abuse of remote API - currently hard-coded, but will likely expose this as a flag in a future release - Add monitoring/reporting of notification channels with pending items - Add monitoring/reporting of notification statistics - total - pending - success - failure - Capture `Ctrl+C` and attempt graceful shutdown - Plumbed `context` throughout majority of application for cancellation and timeout functionality - still learning proper use of this package, so likely many mistakes that will need to be fixed in a future release - Logging - add *many* more debug statements to help with troubleshooting CHANGED - Dependencies - Use `atc0005/go-teams-notify` package - fork of original package with current features and some additional changes not yet accepted upstream - Use `atc0005/send2teams` package - provides wrapper for upstream functionality with message retry, delayfunctionality - provides formatting helper functions - provides additional webhook URL validation - Drop indirect dependency - Update `golang/gddo` - Add commented entries to have Go use local copies of packages for fast prototyping work FIXED - GoDoc formatting - remove forced line-wrap which resulted in unintentional code block formatting of non-code content - Refactor logging, flag handling - not user visible, so not recording as a "change" - Manually flush `http.ResponseWriter` to (massively) speed up response time for client requests - Move template parsing to `main()` in an effort to speed up endpoint response time for client requests REFERENCES - refs #19 - partial work; stubbed out - refs #21 - refs #26 - refs #27 - refs #28
atc0005 · Apr 23, 2020 · 1dd1c72 · 1dd1c72
1 parent bde7d4c
commit 1dd1c72
Show file tree

Hide file tree

Showing 15 changed files with 2,003 additions and 187 deletions.
diff --git a/.gitignore b/.gitignore
@@ -16,3 +16,9 @@
 
 # Generated binaries, checksums
 /release_assets
+
+# Temporary or local content to ignore
+/scratch
+
+# Ignore temporary log files
+/*.log
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -26,6 +26,65 @@ The following types of changes will be recorded in this file:
 
 - placeholder
 
+## [v0.4.0] - 2020-04-23
+
+### Added
+
+- Add support for Microsoft Teams notifications
+  - configurable retry, retry delay settings
+  - rate-limited submissions to help prevent unintentional abuse of remote API
+    - currently hard-coded, but will likely expose this as a flag in a future
+      release
+
+- Add monitoring/reporting of notification channels with pending items
+
+- Add monitoring/reporting of notification statistics
+  - total
+  - pending
+  - success
+  - failure
+
+- Capture `Ctrl+C` and attempt graceful shutdown
+
+- Plumbed `context` throughout majority of application for cancellation and
+  timeout functionality
+  - still learning proper use of this package, so likely many mistakes that
+    will need to be fixed in a future release
+
+- Logging
+  - add *many* more debug statements to help with troubleshooting
+
+### Changed
+
+- Dependencies
+  - Use `atc0005/go-teams-notify` package
+    - fork of original package with current features and some additional
+      changes not yet accepted upstream
+  - Use `atc0005/send2teams` package
+    - provides wrapper for upstream functionality with message retry, delay
+      functionality
+    - provides formatting helper functions
+    - provides additional webhook URL validation
+  - Drop indirect dependency
+  - Update `golang/gddo`
+  - Add commented entries to have Go use local copies of packages for fast
+    prototyping work
+
+### Fixed
+
+- GoDoc formatting
+  - remove forced line-wrap which resulted in unintentional code block
+    formatting of non-code content
+
+- Refactor logging, flag handling
+  - not user visible, so not recording as a "change"
+
+- Manually flush `http.ResponseWriter` to (massively) speed up response time
+  for client requests
+
+- Move template parsing to `main()` in an effort to speed up endpoint response
+  time for client requests
+
 ## [v0.3.3] - 2020-03-14
 
 ### Fixed

diff --git a/README.md b/README.md
@@ -24,6 +24,7 @@ Small utility to assist with building HTTP endpoints
   - [How to use it](#how-to-use-it)
     - [General](#general)
     - [Examples](#examples)
+      - [Local: Send client request details to Microsoft Teams](#local-send-client-request-details-to-microsoft-teams)
       - [Local: View headers submitted by `GET` request using your browser](#local-view-headers-submitted-by-get-request-using-your-browser)
       - [Local: Submit JSON payload using `curl`, receive unformatted response](#local-submit-json-payload-using-curl-receive-unformatted-response)
       - [Local: Submit JSON payload using `curl` to JSON-specific endpoint, get formatted response](#local-submit-json-payload-using-curl-to-json-specific-endpoint-get-formatted-response)
@@ -64,9 +65,17 @@ in testing other tools that submit data via HTTP requests.
     endpoint
   - Optional, colorization and custom ident control for formatted JSON output
 
+- Optional submission of client request details to a user-specified Microsoft
+  Teams channel (by providing a webhook URL)
+
 - User configurable logging settings
   - levels, format and output (see command-line arguments table)
 
+- Message delivery retry support with retry and retry delay values
+  configurable via flag
+  - currently used by Microsoft Teams notifications support, also intended for
+    use with future email notifications support
+
 ### Future
 
 | Priority | Milestone                                                         | Description                                                                                                                     |
@@ -166,16 +175,19 @@ Tested using:
 
 ### Command-line Arguments
 
-| Option       | Required | Default     | Repeat | Possible                                   | Description                                                                                                        |
-| ------------ | -------- | ----------- | ------ | ------------------------------------------ | ------------------------------------------------------------------------------------------------------------------ |
-| `h`, `help`  | No       | `false`     | No     | `h`, `help`                                | Show Help text along with the list of supported flags.                                                             |
-| `port`       | No       | `8000`      | No     | *valid whole numbers*                      | TCP port that this application should listen on for incoming HTTP requests.                                        |
-| `ipaddr`     | No       | `localhost` | No     | *valid fqdn, local name or IP Address*     | Local IP Address that this application should listen on for incoming HTTP requests.                                |
-| `color`      | No       | `false`     | No     | `true`, `false`                            | Whether JSON output should be colorized.                                                                           |
-| `indent-lvl` | No       | `2`         | No     | *1+; positive whole numbers*               | Number of spaces to use when indenting colorized JSON output. Has no effect unless colorized JSON mode is enabled. |
-| `log-lvl`    | No       | `info`      | No     | `fatal`, `error`, `warn`, `info`, `debug`  | Log message priority filter. Log messages with a lower level are ignored.                                          |
-| `log-out`    | No       | `stdout`    | No     | `stdout`, `stderr`                         | Log messages are written to this output target.                                                                    |
-| `log-fmt`    | No       | `text`      | No     | `cli`, `json`, `logfmt`, `text`, `discard` | Use the specified `apex/log` package "handler" to output log messages in that handler's format.                    |
+| Option          | Required | Default        | Repeat | Possible                                   | Description                                                                                                                                                                                       |
+| --------------- | -------- | -------------- | ------ | ------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| `h`, `help`     | No       | `false`        | No     | `h`, `help`                                | Show Help text along with the list of supported flags.                                                                                                                                            |
+| `port`          | No       | `8000`         | No     | *valid whole numbers*                      | TCP port that this application should listen on for incoming HTTP requests.                                                                                                                       |
+| `ipaddr`        | No       | `localhost`    | No     | *valid fqdn, local name or IP Address*     | Local IP Address that this application should listen on for incoming HTTP requests.                                                                                                               |
+| `color`         | No       | `false`        | No     | `true`, `false`                            | Whether JSON output should be colorized.                                                                                                                                                          |
+| `indent-lvl`    | No       | `2`            | No     | *1+; positive whole numbers*               | Number of spaces to use when indenting colorized JSON output. Has no effect unless colorized JSON mode is enabled.                                                                                |
+| `log-lvl`       | No       | `info`         | No     | `fatal`, `error`, `warn`, `info`, `debug`  | Log message priority filter. Log messages with a lower level are ignored.                                                                                                                         |
+| `log-out`       | No       | `stdout`       | No     | `stdout`, `stderr`                         | Log messages are written to this output target.                                                                                                                                                   |
+| `log-fmt`       | No       | `text`         | No     | `cli`, `json`, `logfmt`, `text`, `discard` | Use the specified `apex/log` package "handler" to output log messages in that handler's format.                                                                                                   |
+| `webhook-url`   | No       | *empty string* | No     | *valid webhook URL*                        | The Webhook URL provided by a preconfigured Connector. If specified, this application will attempt to send client request details to the Microsoft Teams channel associated with the webhook URL. |
+| `retries`       | No       | `2`            | No     | *positive whole number*                    | The number of attempts that this application will make to deliver messages before giving up.                                                                                                      |
+| `retries-delay` | No       | `2`            | No     | *positive whole number*                    | The number of seconds that this application will wait before making another delivery attempt.                                                                                                     |
 
 ### Worth noting
 
@@ -194,6 +206,12 @@ Tested using:
 | `text`                 | human-friendly colored output      |
 | `discard`              | discards all logs                  |
 
+- Microsoft Teams webhook URLs have one of two known prefixes. Both are valid
+  as of this writing, but new webhook URLs only appear to be generated using
+  the first prefix.
+  1. <https://outlook.office.com>
+  1. <https://outlook.office365.com>
+
 ## How to use it
 
 ### General
@@ -214,13 +232,32 @@ Tested using:
    - skip this step if you plan to only submit HTTP requests from your own
      system to this application running *on* your system
      - e.g., `localhost:8000`
+1. Run this application using your preferred settings by specifying the
+   appropriate command-line flag options.
+   - e.g., if you specify a valid Outlook/Microsoft Teams webhook URL, this
+     application will attempt to send client request details to the associated
+     Microsoft Teams channel.
 1. Visit the index page for this application at the appropriate IP Address and
    the port you specified
    - e.g., `http://localhost:8000/`
 1. Chose one of the available routes that meet your requirements
 
 ### Examples
 
+#### Local: Send client request details to Microsoft Teams
+
+```ShellSession
+$ ./bounce.exe -webhook-url "https://outlook.office.com/webhook/a1269812-6d10-44b1-abc5-b84f93580ba0@9e7b80c7-d1eb-4b52-8582-76f921e416d9/IncomingWebhook/3fdd6767bae44ac58e5995547d66a4e4/f332c8d9-3397-4ac5-957b-b8e3fc465a8c"
+
+  INFO[0000] bounce is listening on localhost port 8000
+  INFO[0000] Visit http://localhost:8000 in your web browser for details
+  INFO[0030] notifyStatsMonitor: Total: [0 received, 0 pending, 0 success, 0 failure] emit_stats=120s timestamp=12:41:24
+  INFO[0030] notifyStatsMonitor: Teams: [0 total, 0 pending, 0 success, 0 failure] emit_stats=120s timestamp=12:41:24
+  INFO[0030] notifyStatsMonitor: Email: [0 total, 0 pending, 0 success, 0 failure] emit_stats=120s timestamp=12:41:24
+```
+
+Many more options are available. See the list of available flags for details.
+
 #### Local: View headers submitted by `GET` request using your browser
 
 ```ShellSession
@@ -413,6 +450,28 @@ and with colorized JSON output enabled:
   - <https://stackoverflow.com/questions/24556001/how-to-range-over-slice-of-structs-instead-of-struct-of-slices>
   - <https://golangcode.com/get-the-request-ip-addr/>
   - <https://github.com/eddturtle/golangcode-site>
+  - <https://stackoverflow.com/questions/22886598/how-to-handle-errors-in-goroutines>
+    - <https://stackoverflow.com/a/22887491>
+  - <https://groups.google.com/forum/#!topic/golang-nuts/QEORIGKZO24>
+    - explains benefits of 1-deep buffered channels (asynchronous) vs
+      unbuffered (synchronous)
+      - Bakul Shah: *In general, synchronize only when you have to. Here the main thread
+        wants to know when the worker thread terminates but the worker thread
+        doesn't care when the main thread gets around to reading from "done".
+        Using a 1 deep buffer channel exactly captures this usage pattern.  An
+        unbuffered channel would make the worker thread "rendezvous" with the
+        main thread, which is unnecessary.*
+  - <https://golang.org/ref/spec#Length_and_capacity>
+  - <https://gobyexample.com/closures>
+  - <https://golangr.com/closure/>
+
+- Contexts
+  - <https://gobyexample.com/context>
+  - <https://gobyexample.com/timeouts>
+  - <https://golang.org/pkg/context/#WithCancel>
+  - <https://groups.google.com/forum/#!topic/golang-nuts/IJXjldvpNQM>
+  - <https://medium.com/@pinkudebnath/graceful-shutdown-of-golang-servers-using-context-and-os-signals-cc1fa2c55e97>
+  - <https://marcofranssen.nl/go-webserver-with-graceful-shutdown/>
 
 - Request body
   - <https://stackoverflow.com/questions/43021058/golang-read-request-body/43021236#43021236>
@@ -422,6 +481,8 @@ and with colorized JSON output enabled:
 - HTTP Server
   - <https://blog.simon-frey.eu/go-as-in-golang-standard-net-http-config-will-break-your-production/>
   - <https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779>
+  - <https://medium.com/@pinkudebnath/graceful-shutdown-of-golang-servers-using-context-and-os-signals-cc1fa2c55e97>
+  - <https://marcofranssen.nl/go-webserver-with-graceful-shutdown/>
 
 - Logging
   - <https://github.com/apex/log>
@@ -435,6 +496,9 @@ and with colorized JSON output enabled:
 - Splunk / JSON payload
   - [Splunk Enterprise (v8.0.1) > Alerting Manual > Use a webhook alert action](https://docs.splunk.com/Documentation/Splunk/8.0.1/Alert/Webhooks)
 
+- Microsoft Teams
+  - <https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/connectors-using#rate-limiting-for-connectors>
+
 <!-- Screenshot references for use within example section  -->
 [screenshot-uncolored-json-output]: media/v0.2.0/bounce-json-uncolored-output-2020-03-04.png "Uncolored JSON output example screenshot"
 [screenshot-colored-json-output-v0.2.0]: media/v0.2.0/bounce-json-colorizer-output-2020-03-04.png "Colored JSON output example screenshot for v0.2.0 release"
diff --git a/cmd/bounce/client-ip.go b/cmd/bounce/client-ip.go
@@ -18,8 +18,8 @@ import (
 	"github.com/apex/log"
 )
 
-// GetIP gets a requests IP address by reading off the forwarded-for
-// header (for proxies) and falls back to use the remote address.
+// GetIP gets a request's IP address by reading off the forwarded-for
+// header (for proxies) and falls back to using the remote address.
 func GetIP(r *http.Request) string {
 	forwarded := r.Header.Get("X-FORWARDED-FOR")
 	log.WithFields(log.Fields{