Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance AtataContext driver builders #63

Closed
YevgeniyShunevych opened this issue Sep 1, 2017 · 0 comments
Closed

Enhance AtataContext driver builders #63

YevgeniyShunevych opened this issue Sep 1, 2017 · 0 comments
Assignees
Milestone

Comments

@YevgeniyShunevych
Copy link
Member

YevgeniyShunevych commented Sep 1, 2017

Create base abstract DriverAtataContextBuilder<TBuilder, TService, TOptions> class. Move common driver builder methods there. Specific driver builders like ChromeAtataContextBuilder should inherit it.

Add extra methods to DriverAtataContextBuilder`3:

public TBuilder WithOptions(Dictionary<string, object> optionsPropertiesMap);

public TBuilder WithDriverService(Action<TService> serviceInitializer);

public TBuilder WithDriverService(Dictionary<string, object> servicePropertiesMap);

Move WithArguments and add other driver specific methods to appropriate builders, like ChromeAtataContextBuilder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant