#211 NoSuchElementException is thrown when access UIComponent.IsVisib…

…le property of hidden/missing element; Add UIComponent_IsVisible test
atata-framework · Oct 7, 2018 · 9ba5150 · 9ba5150
1 parent 27ab64e
commit 9ba5150
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 2 deletions.
diff --git a/src/Atata.Tests/Components/ContentPage.cs b/src/Atata.Tests/Components/ContentPage.cs
@@ -60,6 +60,9 @@ public class ContentPage : Page<_>
         [FindSettings(Visibility = Visibility.Any)]
         public Content<string, _> HiddenDiv { get; private set; }
 
+        [FindById("hidden-div")]
+        public Content<string, _> HiddenDivWithVisibleVisibility { get; private set; }
+
         [FindById("hidden-div", Visibility = Visibility.Hidden)]
         [ContentSource(ContentSource.TextContent)]
         public Content<string, _> HiddenDivUsingTextContent { get; private set; }

diff --git a/src/Atata.Tests/UIComponentTests.cs b/src/Atata.Tests/UIComponentTests.cs
@@ -1,4 +1,5 @@
-using NUnit.Framework;
+using FluentAssertions;
+using NUnit.Framework;
 using OpenQA.Selenium;
 
 namespace Atata.Tests
@@ -46,6 +47,39 @@ public void UIComponent_Content_Invisible()
                 HiddenDivUsingInnerHtml.Content.Should.Equal("Some <b>text</b>");
         }
 
+        [Test]
+        public void UIComponent_IsVisible()
+        {
+            var page = Go.To<ContentPage>();
+
+            using (StopwatchAsserter.Within(0))
+                page.VisibleDiv.IsVisible.Value.Should().BeTrue();
+
+            using (StopwatchAsserter.Within(0))
+                page.VisibleDiv.IsVisible.Should.BeTrue();
+
+            using (StopwatchAsserter.Within(0))
+                page.VisibleDiv.Should.BeVisible();
+
+            using (StopwatchAsserter.Within(0))
+                page.HiddenDiv.IsVisible.Value.Should().BeFalse();
+
+            using (StopwatchAsserter.Within(0))
+                page.HiddenDiv.IsVisible.Should.BeFalse();
+
+            using (StopwatchAsserter.Within(0))
+                page.HiddenDiv.Should.BeHidden();
+
+            using (StopwatchAsserter.Within(0))
+                page.HiddenDivWithVisibleVisibility.IsVisible.Value.Should().BeFalse();
+
+            using (StopwatchAsserter.Within(0))
+                page.HiddenDivWithVisibleVisibility.IsVisible.Should.BeFalse();
+
+            using (StopwatchAsserter.Within(0))
+                page.HiddenDivWithVisibleVisibility.Should.BeHidden();
+        }
+
         [Test]
         public void UIComponent_Wait_Until_Visible()
         {

diff --git a/src/Atata/Components/UIComponent`1.cs b/src/Atata/Components/UIComponent`1.cs
@@ -163,7 +163,7 @@ internal sealed override bool OnMissing(SearchOptions options)
 
         protected virtual bool GetIsVisible()
         {
-            return Scope.Displayed;
+            return GetScope(SearchOptions.SafelyAtOnce())?.Displayed ?? false;
         }
 
         protected virtual string GetContent()