Add ff_connect_notify config option to configure.sh #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 84397e2 and detected 0 issues on this pull request. View more on Code Climate. |
|
With v0.10 I'm going to change the way the notification plays. I may eventually disable it by default. I'll merge your request on the next patch round. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this option after encountering the #444 bug, where the controller's vibration stops working. I also think it would be a good idea to set it to 'disabled' by default while the bug persists, as I find it very annoying. I'm not sure about your thoughts on this.
I would fix it myself, but I wouldn't know where to start. Thanks!