Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure isolation level is applied to subsequent transactions after setting #202

Conversation

JohnNiang
Copy link
Contributor

Motivation:

Aligning Connection#setTransactionIsolationLevel Behavior with r2dbc-spi Specification. See #192 for more.

Modification:

Change session isolation level as well after invoking Connection#setTransactionIsolationLevel.

Result:

All subsequent transactions will be applied the isolation level set by Connection#setTransactionIsolationLevel.

Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit

src/main/java/io/asyncer/r2dbc/mysql/MySqlConnection.java Outdated Show resolved Hide resolved
src/main/java/io/asyncer/r2dbc/mysql/MySqlConnection.java Outdated Show resolved Hide resolved
@jchrys jchrys added the enhancement New feature or request label Jan 16, 2024
@jchrys jchrys added this to the 1.0.7/0.9.8 milestone Jan 16, 2024
@JohnNiang JohnNiang force-pushed the refactor/align-set-transaction-isolation-level branch from 57981d2 to 919058b Compare January 16, 2024 15:25
@JohnNiang JohnNiang force-pushed the refactor/align-set-transaction-isolation-level branch from 919058b to 55f0ba9 Compare January 17, 2024 16:20
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mirromutth mirromutth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchrys jchrys merged commit 0b3814c into asyncer-io:trunk Jan 19, 2024
12 checks passed
@JohnNiang JohnNiang deleted the refactor/align-set-transaction-isolation-level branch January 19, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants