-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure isolation level is applied to subsequent transactions after setting #202
Merged
jchrys
merged 1 commit into
asyncer-io:trunk
from
JohnNiang:refactor/align-set-transaction-isolation-level
Jan 19, 2024
Merged
Ensure isolation level is applied to subsequent transactions after setting #202
jchrys
merged 1 commit into
asyncer-io:trunk
from
JohnNiang:refactor/align-set-transaction-isolation-level
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchrys
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit
JohnNiang
force-pushed
the
refactor/align-set-transaction-isolation-level
branch
from
January 16, 2024 15:25
57981d2
to
919058b
Compare
jchrys
reviewed
Jan 16, 2024
jchrys
reviewed
Jan 16, 2024
src/main/java/io/asyncer/r2dbc/mysql/message/client/TextQueryMessage.java
Show resolved
Hide resolved
JohnNiang
force-pushed
the
refactor/align-set-transaction-isolation-level
branch
from
January 17, 2024 16:20
919058b
to
55f0ba9
Compare
JohnNiang
commented
Jan 17, 2024
jchrys
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mirromutth
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Aligning Connection#setTransactionIsolationLevel Behavior with r2dbc-spi Specification. See #192 for more.
Modification:
Change session isolation level as well after invoking
Connection#setTransactionIsolationLevel
.Result:
All subsequent transactions will be applied the isolation level set by
Connection#setTransactionIsolationLevel
.