Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singleton Codecs #197

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Singleton Codecs #197

merged 1 commit into from
Jan 15, 2024

Conversation

jchrys
Copy link
Collaborator

@jchrys jchrys commented Jan 14, 2024

Singleton Codecs

Motivation:
A single instance of the Codec is sufficient for the entire application.

Modification:
Implement Singleton pattern for codecs.

Result:
Reduced memory consumption and improved performance.
resolves #196

@jchrys jchrys added the enhancement New feature or request label Jan 14, 2024
@jchrys jchrys added this to the 1.0.7/0.9.8 milestone Jan 14, 2024
@jchrys jchrys changed the title [Draft]Singleton Codecs Singleton Codecs Jan 14, 2024
@jchrys jchrys marked this pull request as ready for review January 14, 2024 16:55
Copy link
Contributor

@mirromutth mirromutth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Motivation:
A single instance of the Codec is sufficient for the entire application.

Modification: Implement Singleton pattern for codecs.

Result:
Reduced memory consumption and improved performance.
resolves #196
@jchrys jchrys merged commit 96c11dc into trunk Jan 15, 2024
12 checks passed
@jchrys jchrys deleted the 1x-singleton branch January 15, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Codec Implementation to Support Singleton Pattern
2 participants