Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MariaDB capabilities support #187

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

jchrys
Copy link
Collaborator

@jchrys jchrys commented Jan 8, 2024

Motivation:

See also #176 .

Modification:

Add recognition for MariaDB, and extend Capability to 64-bits.

Result:

Extend Capability to 64-bits, and extended bits will be read and sent at handshake.

Currently, the driver will unset all MariaDB features, we can enable them after we support these features.

@jchrys jchrys added this to the 1.0.6/0.9.7 milestone Jan 8, 2024
@jchrys jchrys added the enhancement New feature or request label Jan 8, 2024
@jchrys jchrys requested a review from mirromutth January 8, 2024 21:08
@jchrys
Copy link
Collaborator Author

jchrys commented Jan 8, 2024

PTAL @JohnNiang , @mirromutth

Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchrys jchrys merged commit 9ce085e into 0.9.x Jan 9, 2024
12 checks passed
@jchrys jchrys deleted the 0.9.x-mariadb-capabilities-flag-support branch January 9, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants