Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration for MariaDB [0.9.x] #184

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

mirromutth
Copy link
Contributor

Motivation:

Add integration tests for MariaDB. See also #178

Modification:

  • Add MariaDB workflows
  • Correct BitSetCodec in client-preparing for MariaDB, it cannot select BIT by HEX string
  • Correct JSON test cases for MariaDB, it responds TEXT for JSON type
  • Add TEXT integration test to avoid potential bugs due to differences between MySQL and MariaDB
  • Correct README about BIT and TEXT

Result:

MariaDB integration.

- Add MariaDB workflows
- Correct `BitSetCodec` in client-preparing for MariaDB, it cannot select `BIT` by HEX string
- Correct JSON test cases for MariaDB, it responds `TEXT` for `JSON` type
- Add `TEXT` integration test to avoid potential bugs due to differences between MySQL and MariaDB
- Correct README about `BIT` and `TEXT`
@mirromutth mirromutth added the enhancement New feature or request label Dec 22, 2023
@mirromutth mirromutth linked an issue Dec 22, 2023 that may be closed by this pull request
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirromutth mirromutth merged commit 871339d into 0.9.x Dec 22, 2023
12 checks passed
@mirromutth mirromutth deleted the feature/0.9.x/issues-178 branch December 22, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate MariaDB to workflows
2 participants