Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for MariaDB #182

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Add integration tests for MariaDB #182

merged 1 commit into from
Dec 22, 2023

Conversation

mirromutth
Copy link
Contributor

@mirromutth mirromutth commented Dec 22, 2023

Motivation:

Add integration tests for MariaDB. See also #178

Modification:

  • Add workflows
  • Correct BitSetCodec in client-preparing (MariaDB cannot select BIT by HEX string)
  • Correct JSON test cases for MariaDB
  • Add TEXT integration test to avoid potential bugs due to differences between MySQL and MariaDB
  • Correct README about BIT and TEXT

Result:

MariaDB integration.

@mirromutth mirromutth added the enhancement New feature or request label Dec 22, 2023
@mirromutth mirromutth marked this pull request as draft December 22, 2023 06:29
@mirromutth mirromutth force-pushed the feature/issues-178 branch 2 times, most recently from 9710a71 to 7f38c72 Compare December 22, 2023 06:33
@mirromutth mirromutth marked this pull request as ready for review December 22, 2023 06:35
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would you mind consolidating it into a single commit before merging? Thank you!

- Add MariaDB workflows
- Correct `BitSetCodec` in client-preparing for MariaDB, it cannot select `BIT` by HEX string
- Correct JSON test cases for MariaDB, it responds `TEXT` for `JSON` type
- Add `TEXT` integration test to avoid potential bugs due to differences between MySQL and MariaDB
- Correct README about `BIT` and `TEXT`
@mirromutth mirromutth linked an issue Dec 22, 2023 that may be closed by this pull request
@mirromutth mirromutth merged commit 7bbe8af into trunk Dec 22, 2023
12 checks passed
@mirromutth mirromutth deleted the feature/issues-178 branch December 22, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate MariaDB to workflows
2 participants