-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add message concepts doc #944
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
I recommend looking at:
Also, I could not help myself, and dragged community into discussion, let's see if they catch a bait 😃
Also, a question I always wanted to ask @fmvilas |
@derberg Does this reply to your question? https://www.asyncapi.com/docs/tutorials/getting-started/event-driven-architectures#why-event-driven-and-not-message-driven |
@fmvilas not really. I'm more interested if there was some specific reason why we picked to use two terms. Maybe some old issue about it? or maybe you remember 😄 |
Haha! I do know why. Strictly speaking, it's all "messages". A message can be an event, a command, and maybe something else (although I never found a 3rd kind). The spec is a formal document so "message" seems appropriate here. Now that said, event-driven architectures have become more popular in recent years (with the rise of RabbitMQ, Kafka, etc.). And yeah, I mean "event-driven" architectures. Using events only. However, the more popular it got, the more people started doing not-just-events-driven architectures. See, for instance, the case of CQRS (Command-Query Responsibility Segregation). Again, strictly speaking, these are message-driven architectures but the reality is that this name never got popular and most of us are just using event-driven architectures to refer to both, message-driven architectures and event-driven architectures 🤷♂️ I guess it sounds cooler with "event" and that won 😄 So for strict stuff like the spec, it's "message" and for communication or marketing, it's "event" because that's what people tend to use the most. |
Okay so now my question @fmvilas is, should we still go ahead and define the |
@thulieblack we need btw, I got you lots of ideas 😄 -> https://twitter.com/AsyncAPISpec/status/1569426365903953921 and https://www.linkedin.com/feed/update/urn:li:activity:6975192181678436352?commentUrn=urn%3Ali%3Acomment%3A%28activity%3A6975192181678436352%2C6975358655713980416%29 (I did not expect such a great response from the community 🚀 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @thulieblack. I think we should keep it as simple as possible on this page. Maybe you want to mark this PR as ready for review? |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-944--asyncapi-website.netlify.app/ |
Done 👌 |
Co-authored-by: Fran Méndez <[email protected]>
/rtm |
@alequetzalli please always make sure you align the Prev and UpNext buttons properly for adjacent pages also, before merging the PR. I see that with this PR, we again have an issue in |
I revised this and all of the buttons work, there is no problem in this PR. |
@alequetzalli Look into the screenshots below, they are of Prev Button of Tutorials - Overview page: UpNext Button of Channel page: These buttons has to be updated in this PR, while adding new page in between. |
@akshatnema yes, every time a new page is added these buttons will need to be updated and that is correct. Yes, we need a new PR to fix the previous page buttons and that is fine. Her buttons on this page are correct and there is nothing to fix. |
@alequetzalli Yeah, I agree that she added buttons in the page in correct way, but it has to be ensured that every time, a new page is added in docs, it shouldn't break the sequence of the pages linked. For every new page created and added, the buttons should be added on that page and should be updated for the immediate next and previous page. I can't say that this is the job of who created |
I think what you are saying @akshatnema is that per
every page pushed/added to the website someone needs to update the previous
page buttons so they align properly.
|
Exactly 👍 |
I have created a PR #1100 to solve this issue @alequetzalli and @akshatnema |
Description
This PR adds the new
message
concept specRelated issue(s)