feat: serve JSON Schema definitions #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
requested review from
fmvilas,
derberg,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
derberg
approved these changes
Jun 28, 2022
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-841--asyncapi-website.netlify.app/ |
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the feature of serving all definitions (partials) from https://github.com/asyncapi/spec-json-schemas/tree/master/definitions as well. Previously, we were only serving the schemas from https://github.com/asyncapi/spec-json-schemas/tree/master/schemas.
This is especially useful since our
$idvalues on schemas are pointing to our website and those are not being served yet (it will after this PR is merged), e.g. http://asyncapi.com/definitions/2.4.0/asyncapi.jsonI removed the rewrites from the
netlify.tomland instead, we handle it now from inside the handler since we need to check where the file should be served from based on the URL. For example:/schema-store/2.4.0.json-> https://raw.githubusercontent.com/asyncapi/spec-json-schemas/master/schemas/2.4.0.json/definitions/2.4.0/asyncapi.json-> https://raw.githubusercontent.com/asyncapi/spec-json-schemas/master/definitions/2.4.0/asyncapi.json