-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add description to modelina docs #775
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-775--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dule-mart I agree with @starlightknown on the menu. If you could update it too, it would be awesome. Also, please link your PR properly with therelated issue so that once we merge this PR, related issue is closed. Have a look at https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue for more details |
Ok, would work on it.
…On Wed, 18 May 2022 at 08:08, Lukasz Gornicki ***@***.***> wrote:
@Dule-mart <https://github.com/Dule-mart> I agree with @starlightknown
<https://github.com/starlightknown> on the menu. If you could update it
too, it would be awesome.
Also, please link your PR properly with therelated issue so that once we
merge this PR, related issue is closed. Have a look at
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
for more details
—
Reply to this email directly, view it on GitHub
<#775 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH4ASUR2T6C3FFDZ2GJWU63VKSJPZANCNFSM5WE4HDMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alequetzalli Could you take a look on it?
Added the description to the menu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding it :)
@alequetzalli ping ping :) |
@alequetzalli wanna have a look? |
/rtm |
@all-contributors please add @Dule-mart for docs |
I've put up a pull request to add @Dule-mart! 🎉 |
Description
I added the information about generating models from AsynAPI, OpenAPl and JSON schemes to the homepage.
As discussed in the comment asyncapi/modelina#605