fix: add visual on the generators #3492
Conversation
TenzDelek
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request introduces a visual enhancement to the Generator page by adding an image that illustrates the generator's functionality. The new constant Changes
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
TenzDelek
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3492--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
public/img/diagrams/generator.pngis excluded by!**/*.png
📒 Files selected for processing (1)
pages/tools/generator.tsx(2 hunks)
🧰 Additional context used
🪛 eslint
pages/tools/generator.tsx
[error] 45-45: Expected blank line after variable declarations.
(newline-after-var)
[error] 45-45: Replace = with ·=·
(prettier/prettier)
[error] 45-45: Operator '=' must be spaced.
(space-infix-ops)
[error] 55-56: Replace "generator"·className='·mx-auto·h-auto·w-1/2·object-cover'·/>⏎ with 'generator'·className='·mx-auto·h-auto·w-1/2·object-cover'·/>
(prettier/prettier)
[error] 55-55: Unexpected usage of doublequote.
(jsx-quotes)
🔇 Additional comments (1)
pages/tools/generator.tsx (1)
45-45: Verify image asset existence and dimensions.
Let's ensure the image asset exists and has the correct dimensions.
🧰 Tools
🪛 eslint
[error] 45-45: Expected blank line after variable declarations.
(newline-after-var)
[error] 45-45: Replace = with ·=·
(prettier/prettier)
[error] 45-45: Operator '=' must be spaced.
(space-infix-ops)
what might be the issue with permission ? do we need some permission for uploading image? perpexity says
" Codecov action indicates that the process failed due to a lack of required authentication tokens when trying to create a report for a protected branch. "
@sambhavgupta0705 , @derberg
|
public/img/diagrams/generator.png
Outdated
There was a problem hiding this comment.
Can we have this file in .webp format, as we have preferred way of img types as WEBP or SVG?
There was a problem hiding this comment.
have made the changes cc @akshatnema
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3492 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 21 21
Lines 664 664
=======================================
Hits 575 575
Misses 89 89 ☔ View full report in Codecov by Sentry. |
Description
added visual for generator
Related issue(s)
fixes #403
Summary by CodeRabbit