-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #3461
chore: update meetings.json and newsrooom_videos.json #3461
Conversation
WalkthroughThe changes in this pull request primarily involve updates to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3461 +/- ##
=======================================
Coverage 77.22% 77.22%
=======================================
Files 21 21
Lines 663 663
=======================================
Hits 512 512
Misses 151 151 ☔ View full report in Codecov by Sentry. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3461--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
dashboard.json (1)
Line range hint
1-800
: Consider implementing pagination for large data sets.The file contains a significant amount of data. Consider implementing pagination or data segmentation to improve performance and maintainability.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
dashboard.json
(4 hunks)
🔇 Additional comments (5)
dashboard.json (5)
20-28
: LGTM: New PR entry is well-structured.
The new PR entry follows the correct schema with all required fields (id, isPR, title, author, etc.) and maintains consistent formatting.
51-59
: LGTM: Updated PR entry maintains data integrity.
The updated PR entry preserves the required structure while updating the relevant fields (id, title, resourcePath, score).
199-213
: LGTM: New good-first-issue entry is properly formatted.
The new issue entry for the voting summary bug follows the correct schema and includes appropriate labels.
630-633
: LGTM: Label structure is consistent.
The label update maintains the required name/color structure.
145-176
: Verify the score calculation for newly added entries.
The newly added entries appear to have scores that affect their position in the list. Please ensure the scoring algorithm is consistently applied.
✅ Verification successful
Let me gather more information about the scoring calculation by examining the codebase for the scoring logic.
Based on the search results, I found the score calculation logic in scripts/dashboard/build-dashboard.js
. Let me examine the specific implementation more closely.
Now I can provide the final response based on the verification of the scoring implementation:
The score calculation is consistently applied across all entries
The scoring formula finalInteractionsCount / (monthsSince(discussion.timelineItems.updatedAt) + 2) ** 1.8
is applied uniformly to all entries. The scores in the dashboard.json file follow a natural decay pattern, with newer and more active discussions having higher scores (34.46 to 14.07), which is expected given the time-decay factor in the formula.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for score calculation consistency across entries
# Extract and sort scores to analyze distribution
jq -r '.hotDiscussions[] | .score' dashboard.json | sort -nr | head -n 5
Length of output: 167
Script:
#!/bin/bash
# Search for files containing score calculation logic
rg -l "score" --type ts --type js
# Look for specific score calculation implementations
ast-grep --pattern 'function $FUNC($$$) {
$$$
score
$$$
}'
# Also search for any score-related constants or configurations
rg "score" -A 5 -B 5
Length of output: 16803
Script:
#!/bin/bash
# Get the complete score calculation implementation
cat scripts/dashboard/build-dashboard.js | grep -A 10 -B 10 "score:"
Length of output: 792
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Updates
Removals