Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate build script to typescript #3423
base: master
Are you sure you want to change the base?
refactor: migrate build script to typescript #3423
Changes from all commits
2935475
2badba7
ad8c426
eedff42
df75c79
7bf568a
4c51a80
fbb0e61
fd80ef2
f5b38a7
7b6c3b9
a8c12ea
e2097cc
c01fb85
c7a7247
a49c8a2
342432a
9e8efd8
2e94f4c
6b6c4ea
136bd49
3e1536a
2528190
34b1cef
cecc10e
adb15fe
a05df3f
8cb082b
b656d31
40daa1c
717135f
e8e30eb
212e548
652dfc8
d3acd81
09a2fcc
f5fac70
2f782e7
1a1f47d
75a53d4
74d199f
0459723
3df75cf
24ff781
39821b7
00ed279
8bf03da
15ffa2b
02e679a
227995d
be73210
599ab9e
e71fcba
851d1af
81d6cfc
c5b5c9f
a42104e
add1c28
b776dc7
5b82b5d
0916549
b294a6a
93ff413
ba0a99a
c76a556
31103fe
5f7c9bb
5097c35
65a1873
a699313
7942128
bdc0ad0
b87f48a
63a4ddd
647fa16
6f8bb5d
cc3d228
71e9581
32bf9bd
b03f8df
aa8cdb3
2fdab4c
1c9828e
6c129b6
6d6c179
df5aaae
fca9e36
6a26d06
1541bc7
1237899
5268fe2
324e278
ad7268c
1ec94b3
4bf9c1b
f377a66
b96f142
5bb3fde
a08e8fb
9059384
7007d2f
79fc28e
5bba79d
84fa86c
7e49ca8
4820f6a
e1c67c5
15f3aab
98bf565
c93d5a1
fb22081
7ecfba4
470cc18
6e0ef28
7a3730d
7ef191a
b3476a5
9590dd1
d6b0e2a
c0e918f
d142cd0
d15c741
279237c
0b68337
15c0759
76dee32
a220216
e974218
4215898
74a6afa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you added these three rules for scripts folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import/no-extraneous-dependencies: The Scripts are using some of the dependencies which are listed in DevDependencies in package.json file. Since the scripts are ran in the server, it does not matter where the dependencies are listed in package.json file.
This error was occuring in the
scripts/compose.ts
fileno-console: We have several console.log statements in the scripts, which are necessary for build scripts. So I have removed the eslint warning since it is evident for the build scripts to have console statements in them (view your old comment)
require-jsdoc: We are migrating the files to typescript, I have removed the jsdoc rule because it would be irrelevant to keep jsdoc in typescript files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using
npm ci
instead ofnpm install
The change from
npm ci
tonpm install
might lead to inconsistent dependency installations across different environments.npm ci
is preferred in CI environments as it:📝 Committable suggestion
This file was deleted.
This file was deleted.