-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add missing excerpts to hide imports #3270
docs: add missing excerpts to hide imports #3270
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3270--asyncapi-website.netlify.app/ |
lgtm, but there are some addition edits, like removal of empty spaces that I think you also have in another PR, not sure if that is some autoformatter that you use - so yeah, brace yourself - merge conflicts are coming 😉 |
6e7f58b
to
9fca5d8
Compare
WalkthroughThe changes involve updating the front matter metadata of several documentation reports for AsyncAPI from a Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@derberg Yes, you're right, it was my VS Code auto-formatter. I updated the PR, please have a look. |
@bandantonio and here are the conflicts 😄 |
@derberg Yeah 😁😎, I will take care of them later today. |
@quetzalliwrites please approve and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Hey @bandantonio , |
125ba8f
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3270 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 21 21
Lines 664 664
=======================================
Hits 575 575
Misses 89 89 ☔ View full report in Codecov by Sentry. |
125ba8f
to
4d50d1d
Compare
@akshatnema Done. I feel like this PR overlaps with the updates I made in #3393 so there are 0 files changed. |
@bandantonio can you please elaborate this PR |
/update |
Looks like the changes that were intended for this PR are merged with some other PR as per comment #3270 (comment) |
Description
Adds missing excerpts to blog posts to hide jsx-related imports:
Related issue(s)
❗️Must be merged right after #3269
Summary by CodeRabbit
New Features
byline
toexcerpt
, enhancing how introductory information is presented.Documentation