style: added uniform padding around the on this page header
#3249
Conversation
Signed-off-by: Manas Malla <[email protected]>
ManasMalla
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3249--asyncapi-website.netlify.app/ |
|
@ManasMalla Follow proper PR title according to the Contributing Guideline. |
ManasMalla
changed the title
on this page headeron this page header
ManasMalla
changed the title
on this page headeron this page header
|
@devilkiller-ag @MikeRalphson @antoniogarrote @asyncapi-bot would really love a review over this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3249 +/- ##
=======================================
Coverage 59.01% 59.01%
=======================================
Files 21 21
Lines 649 649
=======================================
Hits 383 383
Misses 266 266 ☔ View full report in Codecov by Sentry. |
WalkthroughThe changes in this pull request involve a modification to the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
components/TOC.tsx (1)
50-50: Consider enhancing responsive margin handling.While the current change adds uniform padding, consider making the margin responsive based on viewport size for better visual hierarchy on different devices.
- ${cssBreakingPoint === 'xl' ? 'xl:block' : 'lg:block'} md:top-24 md:max-h-(screen-14) mb-4 z-20`)} + ${cssBreakingPoint === 'xl' ? 'xl:block' : 'lg:block'} md:top-24 md:max-h-(screen-14) mb-2 md:mb-3 lg:mb-4 z-20`)}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
components/TOC.tsx(1 hunks)
🔇 Additional comments (1)
components/TOC.tsx (1)
50-50: LGTM! The margin addition addresses the padding inconsistency.
The addition of mb-4 class provides a uniform bottom margin of 1rem, which aligns with the PR objective of maintaining consistent padding around the "On this page" header.
|
/rtm |
On this
docspage, on smaller device breakpoints, theOn this pagebecomes a sticky header which breaks the uniform padding used through out the website, which has been fixed in this PR.Resolves #3248
Summary by CodeRabbit