Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweetLimit in community/newsroom isn't been reflected #3138

Closed

Conversation

Saumya40-codes
Copy link
Contributor

Description

In community/newsroom page here the amount of tweets which are being loaded to show the timeline is uncontrolled, even though we've mentioned tweetLimit:2 within our code, it turns out that this has been the issue with the main package/library itself and nothing can be done much to solve it.

Current issue:

AsyncAPI.Newsroom._.AsyncAPI.Initiative.for.event-driven.APIs.-.Google.Chrome.2024-08-07.20-50-46.mp4

To fix this issue though we can provide a specific height for this particular component and enable scrolling for the rest of the tweets to be seen:

AsyncAPI.Newsroom._.AsyncAPI.Initiative.for.event-driven.APIs.-.Google.Chrome.2024-08-09.22-05-18.mp4

Related issue(s)

Resolves #3132

Additionally, the problem of user who isn't logged in to twitter seeing a message something like below as pointed out by @sambhavgupta0705

image

Unfortunately this issue exists in twitter's core widget plugin service only ( ref this )

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 920a568
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66ecfedaa8fd150008906525
😎 Deploy Preview https://deploy-preview-3138--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Aug 9, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 48
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3138--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member

Unfortunately this issue exists in twitter's core widget plugin service only ( ref this )

Do we have any fix for this @Saumya40-codes

@Saumya40-codes
Copy link
Contributor Author

Unfortunately this issue exists in twitter's core widget plugin service only ( ref this )

Do we have any fix for this @Saumya40-codes

I dont think so, untill we use official twitter apis.
Although there's one made by vercel here, which fetches the tweets based on the provided ids.

I'll still lookout if any other alternatives still exists

@akshatnema
Copy link
Member

@Saumya40-codes Instead of providing strict height to that element, can't we restrict the embed to only fetch 2 tweets there?

@Saumya40-codes
Copy link
Contributor Author

@Saumya40-codes Instead of providing strict height to that element, can't we restrict the embed to only fetch 2 tweets there?

I tried looking for all possible alternatives, but none really were able to work as intended

@anhtai9710
Copy link

Close with me

Copy link

@anhtai9710 anhtai9710 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me?? Thank pro

@sambhavgupta0705
Copy link
Member

@Saumya40-codes what's the status of this issue?

@Saumya40-codes
Copy link
Contributor Author

Saumya40-codes commented Aug 28, 2024

@Saumya40-codes what's the status of this issue?

  • Current implementation of this PR manages the behaviour of twitter-timeline and our UI correctly imo. I tried with various options to limit the amount of tweets being shown but none of them seemed to work.

  • Same with message being shown to non-logged in twitter user

  • Lastly, if we dont want this, maybe we can locally store the tweets data and load them directly here (more overhead i believe, but this will also do good)

@akshatnema
Copy link
Member

@Saumya40-codes I can't see the tweets even though I'm logged in to twitter

image

@Saumya40-codes
Copy link
Contributor Author

Saumya40-codes commented Aug 31, 2024

@Saumya40-codes I can't see the tweets even though I'm logged in to twitter

image

Twitter plugins needs to be inconsistent enough then imo

here im using their official site for the same ( one from browser having not logged in to twitter and otherwise)

image

here is the link for the same: https://publish.twitter.com/?dnt=1&query=%40AsyncAPISpec&widget=Timeline

Additionally, this issue is pretty much from twitter plugins only, ref this and this

@sambhavgupta0705
Copy link
Member

@Saumya40-codes any update on this issue?

@Saumya40-codes
Copy link
Contributor Author

@Saumya40-codes any update on this issue?

Nope the ones I stated here looks only to be probable fixes:

image

Rest I'll be needing some suggestions on those for proceeding

@sambhavgupta0705
Copy link
Member

@derberg I think we need your assistance here

@sambhavgupta0705
Copy link
Member

Sorry @Saumya40-codes we have moved this issue under bounty program so @akshatnema will be working on this one.
You can pick any other issue

@Saumya40-codes Saumya40-codes deleted the handle-twitter-data branch September 24, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] tweetLimit in community/newsroom isn't been reflected
5 participants