Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed typo in the MAINTAINERS.json file #2637

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix: fixed typo in the MAINTAINERS.json file #2637

merged 1 commit into from
Feb 6, 2024

Conversation

azmatroshan
Copy link
Contributor

Fixes #2633

fixed typo in the MAINTAINERS.json file that was causing Flaky pages/community/tsc.cy.js test failure on some cypress-runs.

…ages/community/tsc.cy.js test failure on some cypress-runs
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit aa1f4dc
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65c27f7b6a5a7c00083e4897
😎 Deploy Preview https://deploy-preview-2637--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 39
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2637--asyncapi-website.netlify.app/

@anshgoyalevil
Copy link
Member

There was a typo in this PR which caused this regression.

@anshgoyalevil
Copy link
Member

anshgoyalevil commented Feb 6, 2024

@sambhavgupta0705 Could you please create a PR in community repo as well, with this fix 🚀

@anshgoyalevil
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 5b02cb4 into asyncapi:master Feb 6, 2024
28 checks passed
@sambhavgupta0705
Copy link
Member

ahhh @anshgoyalevil I don't think we should have done changes in this file manually as it is being handled by workflows only so opening a pr directly in community repo would have been a better approach for this

@anshgoyalevil
Copy link
Member

ahhh @anshgoyalevil I don't think we should have done changes in this file manually as it is being handled by workflows only so opening a pr directly in community repo would have been a better approach for this

Yes maybe. Though I am not sure if updating a word is also compared against the upstream, or only new TSC Member addition triggers that 🤔

@sambhavgupta0705
Copy link
Member

yes it will because the workflow is written in this way that it first convert that whole yaml file into json and then it copies it from community repo and paste it in website so if we even make a word change then also the whole workflow will be triggered

for this PR the changes made in this will be overwritten by the pr I will open in community repo
https://github.com/asyncapi/community/blob/df1082f746efc344b5e5e6f8609af124eb2919b0/.github/workflows/update-website-tsc.yml

@anshgoyalevil
Copy link
Member

Ahh got it. So, should we revert this PR?

@sambhavgupta0705
Copy link
Member

sambhavgupta0705 commented Feb 6, 2024

No it won't make change as when my PR of community repo will be merged then everything will be on track so IMO we should not make any changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky pages/community/tsc.cy.js test failing on some cypress-runs
4 participants