-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed typo in the MAINTAINERS.json file #2637
Conversation
…ages/community/tsc.cy.js test failure on some cypress-runs
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2637--asyncapi-website.netlify.app/ |
There was a typo in this PR which caused this regression. |
@sambhavgupta0705 Could you please create a PR in |
/rtm |
ahhh @anshgoyalevil I don't think we should have done changes in this file manually as it is being handled by workflows only so opening a pr directly in community repo would have been a better approach for this |
Yes maybe. Though I am not sure if updating a word is also compared against the upstream, or only new TSC Member addition triggers that 🤔 |
yes it will because the workflow is written in this way that it first convert that whole yaml file into json and then it copies it from community repo and paste it in website so if we even make a word change then also the whole workflow will be triggered for this PR the changes made in this will be overwritten by the pr I will open in community repo |
Ahh got it. So, should we revert this PR? |
No it won't make change as when my PR of community repo will be merged then everything will be on track so IMO we should not make any changes |
Fixes #2633
fixed typo in the MAINTAINERS.json file that was causing Flaky pages/community/tsc.cy.js test failure on some cypress-runs.