Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove excess quotes in Restricted parameters object #2474

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

Tenischev
Copy link
Member

Description

  • found a small typo when pass through

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 378e012
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65de9834808f4e0008519b19
😎 Deploy Preview https://deploy-preview-2474--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Dec 19, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 35
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2474--asyncapi-website.netlify.app/

@akshatnema akshatnema changed the title fix: remove excess quotes in Restricted parameters object docs: remove excess quotes in Restricted parameters object Dec 20, 2023
Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
cc: @anshgoyalevil

Copy link
Member

@anshgoyalevil anshgoyalevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tenischev

@anshgoyalevil
Copy link
Member

/rtm

@sambhavgupta0705
Copy link
Member

@alequetzalli we need your approval here

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@sambhavgupta0705
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 02c2978 into asyncapi:master Feb 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants