Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: tutorial for bindings with Kafka #2318
docs: tutorial for bindings with Kafka #2318
Changes from 27 commits
232bb55
b5fdf9f
94e4f50
a8020e0
9506b89
a4217aa
fb5d1e8
60510bf
efcd397
5cd1ac6
f3faba0
bee1145
7edaf18
cc4bcb1
2ca88a2
c6746db
60172ce
8a8ea80
bc630a8
29383e9
3e201f2
74dc1f3
abba6f8
ebab8c0
98d0cdb
a33769a
4ef8542
f50d8a8
b3f6d3d
822a08a
39f25e1
37bba1d
3b2c352
f97c06c
bc47bf1
d2b19a7
1ef1c5e
fb2869a
ac7da56
4490849
6c57f54
9626df0
b3b1bb7
194e6d5
7141d68
3af3bab
56610de
87d457c
024e64a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please consider modification of this paragraph
here you should just have an intro to kafka binding and point to https://github.com/asyncapi/bindings/tree/master/kafka
then the links that you have, to specific objects, like message or others, they are useful, but super useful they would be if instead of here, they are in respective sections. So for example, as reader I would prefer to have a link to server kafka binding in server-related section, like a sentence below each code snippet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please always validate with studio if your snippets are correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason why we have bindingVersion specific to every configuration? Also, does this mean that in the final version, we have 4/5 different bindingVersion or we have just one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.