-
-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add translations guide for AsyncAPI website #2130
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
//cc @magicmatatjahu |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2130--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Sorry for such a delay. I added some comments but we also need @alequetzalli review :)
Signed-off-by: Ansh Goyal <[email protected]>
Thanks @magicmatatjahu for the fine-tuning. The wait was worth it 🛩️ A green flag from @alequetzalli (Docs Ecosystem Authtor 😄) is left |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2130--asyncapi-website.netlify.app/ |
@alequetzalli Hey, could you please review this PR 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rewrote the parts that were rough/confusing. Looks good now 🚢
Thank you for this great documentation @anshgoyalevil 🥳
Closing this PR as changes are incorporated in #2184 |
@akshatnema This PR wasn't supposed to be closed 🙂 It is related to changes related to docs. The PR that needs to be closed is: #2131 actually :) |
/rtm |
/rtm |
Description
Related issue(s)
part of #2039