Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add translations guide for AsyncAPI website #2130

Merged
merged 32 commits into from
Feb 12, 2024

Conversation

anshgoyalevil
Copy link
Member

Description

  • This PR introduces the translation guide
  • It would help the community in introducing or improving new localizations.
  • This PR is a part of AsyncAPI Mentorship Program 2023

Related issue(s)
part of #2039

@netlify
Copy link

netlify bot commented Sep 9, 2023

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit b1b8b49
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65c9eceed369f900081eaa3b
😎 Deploy Preview https://deploy-preview-2130--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anshgoyalevil
Copy link
Member Author

//cc @magicmatatjahu

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 30
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-2130--asyncapi-website.netlify.app/

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Sorry for such a delay. I added some comments but we also need @alequetzalli review :)

ADDING_TRANSLATIONS.md Outdated Show resolved Hide resolved
ADDING_TRANSLATIONS.md Outdated Show resolved Hide resolved
ADDING_TRANSLATIONS.md Outdated Show resolved Hide resolved
ADDING_TRANSLATIONS.md Outdated Show resolved Hide resolved
ADDING_TRANSLATIONS.md Outdated Show resolved Hide resolved
ADDING_TRANSLATIONS.md Outdated Show resolved Hide resolved
ADDING_TRANSLATIONS.md Outdated Show resolved Hide resolved
ADDING_TRANSLATIONS.md Outdated Show resolved Hide resolved
ADDING_TRANSLATIONS.md Outdated Show resolved Hide resolved
ADDING_TRANSLATIONS.md Outdated Show resolved Hide resolved
@anshgoyalevil
Copy link
Member Author

Thanks @magicmatatjahu for the fine-tuning. The wait was worth it 🛩️

A green flag from @alequetzalli (Docs Ecosystem Authtor 😄) is left

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Nov 21, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 37
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2130--asyncapi-website.netlify.app/

@anshgoyalevil
Copy link
Member Author

anshgoyalevil commented Jan 31, 2024

@alequetzalli Hey, could you please review this PR 😄

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote the parts that were rough/confusing. Looks good now 🚢

Thank you for this great documentation @anshgoyalevil 🥳

@akshatnema
Copy link
Member

Closing this PR as changes are incorporated in #2184

@akshatnema akshatnema closed this Feb 11, 2024
@anshgoyalevil
Copy link
Member Author

@akshatnema This PR wasn't supposed to be closed 🙂 It is related to changes related to docs.

The PR that needs to be closed is: #2131 actually :)

@anshgoyalevil anshgoyalevil reopened this Feb 11, 2024
@anshgoyalevil
Copy link
Member Author

/rtm

@anshgoyalevil
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 82fa3dc into asyncapi:master Feb 12, 2024
20 checks passed
@anshgoyalevil anshgoyalevil deleted the i18n-docs branch February 24, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants