Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: created a Glossary list #1784

Closed

Conversation

CynthiaPeter
Copy link
Contributor

Description

  • I created a Glossary list for the Community/Styleguide content bucket.
  • I added some words from the community.

Related issue(s)
Reference to #1294

Notes:

  • I need more words.
  • I have some comments at the bottom of the page and will like some insight into those.

@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 663dcbb
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6499628d4596f800084afc47
😎 Deploy Preview https://deploy-preview-1784--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@CynthiaPeter CynthiaPeter changed the title docs: Created a Glossary list docs: created a Glossary list Jun 14, 2023
@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Jun 16, 2023
Comment on lines 85 to 89
Secondly, in writing AsyncAPI, are there any variants? like these:

- asyncAPI
- Async API

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Many people write it INCORRECTLY. 😂

The only correct way to write our oss project name is AsyncAPI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Done this.
We can highlight this information in an "important" callout.

image

Let me know if this is something we want to do or if there are other ways to make this obvious; that'll be great too. Also, I'll like to know what flavour of Markdown we use for writing docs. It's my first time using the "Remember" tag. I kept spelling it with low caps "r" and wondered what I did wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! A remember block could make great sense since this is a VERY common mistake :D


AsyncAPI specification
AsyncAPI spec
AsyncAPI file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The history behind all these variations is that for a while, folks were saying BOTH AsyncAPI file and AsyncAPI document. Naturally, this raises confusion due to it's inconsistency.

Finally, sometime late last year the community decided to stick to one term: AsyncAPI document. So for this Glossary and all other docs, the only mentions should be for the AsyncAPI document.

Comment on lines 77 to 78
AsyncAPI specification
AsyncAPI spec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick to the full spelling of "AsyncAPI specification" and only list/define that term in this Glossary. Adding the abbreviation of "AsyncAPI spec" would be superfluous. 😄✌🏽


I noticed that in different cases, it is spelt differently. Do we want to specify anything?

Finally, I'll apprecite new words to be added. Thanks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since AsyncAPI currently built 6 tools, as shown on our website, I would also include a definition for all 6 of those tools.

Screen Shot 2023-06-15 at 6 59 33 PM

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING first draft! ✨✨

@@ -0,0 +1,105 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyo, your directory structure is wrong because it's missing the Community content bucket folder. 😄 We are storing our Style Guide in the Community content bucket so your directory needs to be:
asyncapi.com/docs/community/style-guide/glossary.

Copy link
Member

@quetzalliwrites quetzalliwrites Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. I didn't mention this before because we JUST merged our new Community content bucket into the docs this week... but now that we have a LIVE Community content bucket in the docs, we actually should be authoring community docs directly in the /Community repo. (We actually have similar behavior/process in place for tools and specification docs too! Tools and specification docs are actually stored in their repoes and then copies to our website repo docs.)

I would work on your second draft and create a NEW PR in the community repo when you have it ready to review.

Please let me know if this doesn't make sense!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will need more explanation on this.
I currently have the following and the docs resides inside the 'Pages' folder as shown in the screenshots below.
image

second screenshot.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly! The sub-folder community inside the /docs directory is where the Style Guide will live.

That said, please note that your glossary document should be inside a NEW sub-folder of Style Guide. The URL for your document should be as follows: asyncapi.com/docs/community/style-guide/glossary.

Please let me know if this makes sense, we can always have another quick call too 💜

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I noticed that, too and fixed it up. Thanks for calling that out.

Copy link
Member

@quetzalliwrites quetzalliwrites Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOOOO CLOSE, @CynthiaPeter. 😄✌🏽

1

Please note, however, that the sub-directory style-guide is missing a dash to separate the words.

As noted above, the URL for your document should be as follows: asyncapi.com/docs/community/style-guide/glossary.

2

Your new sub-directory style-guide is missing it's own section.md and index.md files. Sub-directories need those elements too. (please let me know if this doesn't make sense!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alequetzalli
I fixed these.

However, is there a guide on how we decide what goes into the _section.md and index.md page?

And if you have the time, I'd like to connect and have a call to talk about this and the onboarding guide. I have some drafts and ideas, but I am not exactly sure how to go about it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is def best practices on what you need to place in both those files. Let's go over this again in a call 😄.

I see you sent me a DM to pick a day/time for that call, so I will follow up with you offline to help unblock you.

@CynthiaPeter
Copy link
Contributor Author

Hello @alequetzalli

Can you point me to the specific community repo where I must create the PR? I assume it is this one, but I'll like to be sure.

Thank you.

Copy link
Member

Yes, that is exactly right! That is the only community repo we have, so that is the correct place to put your work ✨

Copy link

github-actions bot commented Nov 1, 2023

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Nov 1, 2023
@octonawish-akcodes
Copy link
Contributor

Don't you think we should close this PR as the related work is already been shifted by @CynthiaPeter to the community repo PR suggested by @alequetzalli ?

@quetzalliwrites
Copy link
Member

Correct, closing cause this is going to be taken care of via asyncapi/community#769.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs stale
Projects
Status: Community PR under Review 🧐
Development

Successfully merging this pull request may close these issues.

4 participants