Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build cache settings #1669

Merged
merged 20 commits into from
May 29, 2023
Merged

feat: add build cache settings #1669

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ee8c4c1
feat: added cache settings
sambhavgupta0705 May 14, 2023
00eaff8
caching deployment
sambhavgupta0705 May 14, 2023
bd451ef
Revert "caching deployment"
sambhavgupta0705 May 14, 2023
9fbc75d
Revert "feat: added cache settings"
sambhavgupta0705 May 14, 2023
ae8841e
fix: cache settings
sambhavgupta0705 May 14, 2023
6ddc084
environment variable changes
sambhavgupta0705 May 14, 2023
2aad057
cache control refactored
sambhavgupta0705 May 14, 2023
0fbbb2b
removed package.json
sambhavgupta0705 May 15, 2023
055508f
Merge branch 'master' into cache
sambhavgupta0705 May 15, 2023
b36142e
removed the cache control from netlify.toml
sambhavgupta0705 May 17, 2023
7e3e4a9
Merge branch 'master' into cache
sambhavgupta0705 May 17, 2023
193207a
Merge branch 'master' into cache
sambhavgupta0705 May 18, 2023
08a6087
Merge branch 'master' into cache
sambhavgupta0705 May 18, 2023
088c30f
Merge branch 'master' into cache
sambhavgupta0705 May 22, 2023
5f5c69f
netlify error fix
sambhavgupta0705 May 23, 2023
c74b252
Merge branch 'master' into cache
sambhavgupta0705 May 23, 2023
287593b
nfixed node and npm version
sambhavgupta0705 May 23, 2023
e416faf
Merge branch 'master' into cache
sambhavgupta0705 May 23, 2023
8174b2a
Merge branch 'master' into cache
sambhavgupta0705 May 28, 2023
6c653f3
Merge branch 'master' into cache
sambhavgupta0705 May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[[headers]]
for = "/*"
[headers.values]
Cache-Control = "public, max-age=3600"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the scope of the issue is to enable cache for build,

why is this header added? what will it change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is added to control how caching should be performed
The value public, max-age=3600 specifies that the response can be cached by both public and private caches
,and the caching age is 3600 seconds

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sambhavgupta0705

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but how is it helping with cache build? this is a setting for the server and client side caching. So imho totally unrelated and probably something we should not add

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well it just tell the server how long the response should be considered fresh and cacheable.So we can remove it as it doesn't help us that much in build

X-Frame-Options = "ALLOW-FROM https://www.youtube.com/"
Access-Control-Allow-Origin = "*"

Expand All @@ -10,6 +11,7 @@
publish = "out"

[build.environment]
NETLIFY_NEXT_PLUGIN_SKIP = "true"
derberg marked this conversation as resolved.
Show resolved Hide resolved
derberg marked this conversation as resolved.
Show resolved Hide resolved
NODE_VERSION = "16.13.2"
NPM_VERSION = "8.1.2"

Expand All @@ -32,3 +34,6 @@ path = "/definitions/*"
[[edge_functions]]
function = "serve-definitions"
path = "/schema-store/*"

[[plugins]]
package = "@netlify/plugin-nextjs"
sambhavgupta0705 marked this conversation as resolved.
Show resolved Hide resolved
Loading