-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: new style guide - Grammar #1343
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @Arya-Gupta please add meta-data, |
Co-authored-by: V Thulisile Sibanda <[email protected]>
Co-authored-by: V Thulisile Sibanda <[email protected]>
Co-authored-by: V Thulisile Sibanda <[email protected]>
title: Grammar | ||
description: This page explains how to use Grammar when writing docs | ||
--- | ||
#Grammar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#Grammar | |
## Grammar |
Please add introduction content to the first header, introducing the reader to this Grammar
Style Guide document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there @Arya-Gupta! Thank you so much for your incredible patience in waiting for me to review your work... interviewing and onboarding the 2023 gsod folks took more of my energy than I anticipated, and I had to put Style Guide tasks in the back burner for a little bit 😬.
I hope you are still interested in contributing to this issue, I really do look forward to continuing working with you on this one 😄✌🏽. Thank you again for your hard work so far!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks SOOOO CLOSE to being done @Arya-Gupta! Once again, great job. 🔥
There is just one pending item to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks amazing, great job!! :)
Heyo, your directory structure is wrong because it's missing a dash to separate the words |
P.S. I didn't mention this before because we JUST merged our new I would work on your second draft and create a NEW PR in the community repo when you have it ready to review. Please let me know if this doesn't make sense! |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1343--asyncapi-website.netlify.app/ |
Thank you! I've fixed the directory issue. There were some merge conflicts which I resolved, I hope I did it correctly. |
I'm a bit confused. You want me to make the same PR here? |
Yes, that is exactly right 😄. No worries, I can understand the confusion. Since we have a call tmw, we can go over this in more detail and I can explain to you again why we are making this change. ✌🏽 |
Closing this pull request as this is being moved over to Community. |
Fix: #1250
Added style guide for grammar: