Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added link to YT video to TSC page #1141

Merged
merged 10 commits into from
Dec 6, 2022
Merged

feat: added link to YT video to TSC page #1141

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a455f46
feat(enhancement) : added link to YT video to TSC page
Anurag607 Dec 5, 2022
a4a240f
feat: add YT link to TSC para and question card
Anurag607 Dec 5, 2022
2acf190
feat: add YT link to TSC para and question card
Anurag607 Dec 5, 2022
6915e9f
feat: alter font weight of the link
Anurag607 Dec 5, 2022
f693cb4
feat: replace old YT link with new docs link
Anurag607 Dec 5, 2022
72e3dca
feat: fixed font weight issues in TextLink component
Anurag607 Dec 5, 2022
7033ef2
feat: fixed font weight issues in TextLink component
Anurag607 Dec 5, 2022
8b67c2c
Merge branch 'master' into local
akshatnema Dec 6, 2022
2fe0324
Merge branch 'local' of https://github.com/Anurag607/AsyncAPI-Website…
Anurag607 Dec 5, 2022
8820aba
Merge branch 'master' into local
akshatnema Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions components/typography/TextLink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Link from 'next/link'
import { twMerge } from 'tailwind-merge'
export default function TextLink({
href,
className,
Expand All @@ -7,7 +8,7 @@ export default function TextLink({
id
}) {

const classNames = `text-secondary-500 underline hover:text-gray-800 font-medium transition ease-in-out duration-300 ${className || ''}`
const classNames = twMerge(`text-secondary-500 underline hover:text-gray-800 font-medium transition ease-in-out duration-300 ${className || ''}`)

return (
<>
Expand All @@ -20,4 +21,4 @@ export default function TextLink({
</>
)

}
}
16 changes: 15 additions & 1 deletion pages/community/tsc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import GenericLayout from "../../components/layout/GenericLayout";
import TSCMembersList from "../../config/TSC_MEMBERS.json";
import {sortBy} from 'lodash';
import NewsletterSubscribe from "../../components/NewsletterSubscribe";
import TextLink from '../../components/typography/TextLink';
import { twMerge } from "tailwind-merge";

function addAdditionalUserInfo(user) {
const userData = {
Expand Down Expand Up @@ -72,6 +74,11 @@ export default function TSC() {
can also build a great AsyncAPI-based project that we don't have
yet in our GitHub organization and donate it (we'll ask you to
stay as a maintainer).
Follow this
<TextLink href="https://github.com/asyncapi/community/blob/master/TSC_MEMBERSHIP.md" target="_blank" className={twMerge(`text-base font-normal text-blue-500 hover:text-sky-400 no-underline`)}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the twMerge function from file as it is not needed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the PR according to the review

Link
</TextLink>
&nbsp;to know more!
</p>
</div>
<div>
Expand Down Expand Up @@ -225,7 +232,14 @@ function QuestionCard() {
src="/img/avatars/questionmark.webp"
className="mx-auto rounded-full h-20 w-20 xl:w-28 xl:h-28"
/>
<div className="my-4">Become a member!</div>
<div className="my-4">
Want to become a member?
Follow this
<TextLink href="https://github.com/asyncapi/community/blob/master/TSC_MEMBERSHIP.md" target="_blank" className={twMerge("text-base font-normal text-sky-600 hover:text-sky-400 no-underline")}>
Link
</TextLink>
&nbsp;to know more!
</div>
</li>
);
}
Expand Down