Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added link to YT video to TSC page #1141

Merged
merged 10 commits into from
Dec 6, 2022
15 changes: 14 additions & 1 deletion pages/community/tsc.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import GenericLayout from "../../components/layout/GenericLayout";
import TSCMembersList from "../../config/TSC_MEMBERS.json";
import {sortBy} from 'lodash';
import NewsletterSubscribe from "../../components/NewsletterSubscribe";
import TextLink from '../../components/typography/TextLink';

function addAdditionalUserInfo(user) {
const userData = {
Expand Down Expand Up @@ -72,6 +73,11 @@ export default function TSC() {
can also build a great AsyncAPI-based project that we don't have
yet in our GitHub organization and donate it (we'll ask you to
stay as a maintainer).
Follow this
<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-base text-blue-500 hover:text-sky-400 no-underline">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-base text-blue-500 hover:text-sky-400 no-underline">
<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-base font-normal text-blue-500 hover:text-sky-400 no-underline">

The font-weight of the text is getting large, so it should be made according to the remaining text in the paragraph.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done..

Link
</TextLink>
&nbsp;to know more!
</p>
</div>
<div>
Expand Down Expand Up @@ -225,7 +231,14 @@ function QuestionCard() {
src="/img/avatars/questionmark.webp"
className="mx-auto rounded-full h-20 w-20 xl:w-28 xl:h-28"
/>
<div className="my-4">Become a member!</div>
<div className="my-4">
Want to become a member?
Follow this
<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-sky-600 hover:text-sky-400 no-underline">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-sky-600 hover:text-sky-400 no-underline">
<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="font-normal text-sky-600 hover:text-sky-400 no-underline">

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done...

Link
</TextLink>
&nbsp;to know more!
</div>
</li>
);
}
Expand Down